From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout.efficios.com (smtpout.efficios.com [167.114.26.122]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F2D2B658; Thu, 24 Oct 2024 18:19:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=167.114.26.122 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729794001; cv=none; b=fisoYmhwqXj6xeequ5F6/J4n3synZSgVkDC0sAfBw8TGvN055V9/glaqtxlK+mlg0DhQWDOIzg8Na+riV+oGQOnkYmgq9pojXvPt8Nm/HERrDNJDe3wk7QoJFbOp1VY6J3JHr+IldpxpPtkg/RfHwfOLe1YVxXdCiH0OAvEGQS4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729794001; c=relaxed/simple; bh=vJOZ077V7U7xL8fp19/FQuF9IoMjhGoJNSwoKDSLSmg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=SjRnQKU5ws2kM/4qacFtAgFjmQSL4IAZ9pVE30XAlg0/67DjJvx6dI59+CyZPOUbNnrBEaKTBAjER58oCQys+UUpDmICRG7vFguEtNq8VbrzMOcCW+HoIIHB7ksf1c4pH5OTRFu/fOsJKD0HcQd3GGEV0EVYAhJgFKRNGN3NmxY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=efficios.com; spf=pass smtp.mailfrom=efficios.com; dkim=pass (2048-bit key) header.d=efficios.com header.i=@efficios.com header.b=oFvVjLuo; arc=none smtp.client-ip=167.114.26.122 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=efficios.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=efficios.com header.i=@efficios.com header.b="oFvVjLuo" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=efficios.com; s=smtpout1; t=1729793991; bh=vJOZ077V7U7xL8fp19/FQuF9IoMjhGoJNSwoKDSLSmg=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=oFvVjLuo4iwDOrEJPr1OBS7yIqqvCElQrYnuWCkadYvwDiUNV2VpTFG+/RqI3zHwp ndDF5hOry4uU1KKDjkhzypApsqklNTBA9Ml2wAMhiVxdGtaZcJcfWpQINf/uVIYU0g O8yeh4ou5XzQiH864Hv/+HZjprnj6zBgjyOVvBnl58Z7vtOXIxNPJJktTcfhIfGKix xkHZ9tQKk3vm8aG9D310+IYZ3X9chkqDanwkBXmxaGLqFUfe1VfRB+/kph3QizeiFC UAZKFl6Tm5ek6XnNyl62t1CECVqpVvy2NNhTxAOXOsGbZ/FNxmX9B10prV0thKEQPT 4RwWwAVCY31Qg== Received: from [172.16.0.134] (96-127-217-162.qc.cable.ebox.net [96.127.217.162]) by smtpout.efficios.com (Postfix) with ESMTPSA id 4XZDj26xJnzvS7; Thu, 24 Oct 2024 14:19:50 -0400 (EDT) Message-ID: Date: Thu, 24 Oct 2024 14:18:08 -0400 Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH] tracing: Fix syscall tracepoint use-after-free To: Andrii Nakryiko , Steven Rostedt , Alexei Starovoitov Cc: Jordan Rife , Arnaldo Carvalho de Melo , Alexander Shishkin , Alexei Starovoitov , bpf , Joel Fernandes , LKML , Mark Rutland , Masami Hiramatsu , Ingo Molnar , Michael Jeanson , Namhyung Kim , "Paul E. McKenney" , Peter Zijlstra , syzbot+b390c8062d8387b6272a@syzkaller.appspotmail.com, Yonghong Song References: <20241023145640.1499722-1-jrife@google.com> <7bcea009-b58c-4a00-b7cd-f2fc06b90a02@efficios.com> <20241023220552.74ca0c3e@rorschach.local.home> From: Mathieu Desnoyers Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2024-10-24 13:12, Andrii Nakryiko wrote: [...] > And as Alexei asked, where are the applied > patches adding faultable tracepoints? > On linux-next next-20241024 : 0850e1bc88b1 tracing/bpf: Add might_fault check to syscall probes cdb537ac4179 tracing/perf: Add might_fault check to syscall probes a3204c740a59 tracing/ftrace: Add might_fault check to syscall probes a363d27cdbc2 tracing: Allow system call tracepoints to handle page faults <---- This is where bisection points as first offending commit. 4aadde89d81f tracing/bpf: disable preemption in syscall probe 65e7462a16ce tracing/perf: disable preemption in syscall probe 13d750c2c03e tracing/ftrace: disable preemption in syscall probe 0e6caab8db8b tracing: Declare system call tracepoints with TRACE_EVENT_SYSCALL Thanks, Mathieu -- Mathieu Desnoyers EfficiOS Inc. https://www.efficios.com