Re: [PATCH bpf-next v2 2/2] selftests/bpf: Enable gotox tests for riscv64

[Pu Lehui <pulehui@huawei.com>]

On 2026/9/28 10:31, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] bpf: missing architecture guards for riscv64 gotox tests
> --
> 
> commit 1d33b2e23d145afdb7fdcec7bed2452e5b940956
> Author: Chen Pei <cp0613@linux.alibaba.com>
> 
> selftests/bpf: Enable gotox tests for riscv64
> 
> This commit adds riscv64 to the architecture whitelist in verifier_gotox.c
> because the JIT now supports the gotox instruction and jump tables.
> 
>> diff --git a/tools/testing/selftests/bpf/progs/verifier_gotox.c b/tools/testing/selftests/bpf/progs/verifier_gotox.c
>> index f5a9878c7b8d4..96a9d914930ee 100644
>> --- a/tools/testing/selftests/bpf/progs/verifier_gotox.c
>> +++ b/tools/testing/selftests/bpf/progs/verifier_gotox.c
>> @@ -6,7 +6,9 @@
>>   #include "bpf_misc.h"
>>   #include "../../../include/linux/filter.h"
>>   
>> -#if defined(__TARGET_ARCH_x86) || defined(__TARGET_ARCH_arm64) || defined(__TARGET_ARCH_powerpc)
>> +#if defined(__TARGET_ARCH_x86) || defined(__TARGET_ARCH_arm64) || \
>> +	defined(__TARGET_ARCH_powerpc) || \
>> +	(defined(__TARGET_ARCH_riscv) && __riscv_xlen == 64)
> 
> [Severity: Low]
> Are there other files that need their architecture guards updated for riscv64
> gotox tests to prevent a regression in test coverage?
> 
> For example, tools/testing/selftests/bpf/prog_tests/bpf_insn_array.c has:
> 
> #if defined(__x86_64__) || defined(__powerpc__) || defined(__aarch64__)
> static int map_create(__u32 map_type, __u32 max_entries)
> {
>      ...
> 
> This skips the bpf_insn_array test suite on riscv64, which heavily exercises
> the gotox jump table logic.
> 
> Similarly, tools/testing/selftests/bpf/progs/compute_live_registers.c has:
> 
> #if defined(__TARGET_ARCH_x86) || defined(__TARGET_ARCH_arm64)
> 
> SEC("socket")
> __log_level(2)
> __msg("2: .1........ (07) r1 += 8")
> __msg("3: .1........ (79) r2 = *(u64 *)(r1 +0)")
> __msg("4: ..2....... (b7) r3 = 1")
> __msg("5: ..23...... (b7) r4 = 2")
> __msg("6: ..234..... (0d) gotox r2")
> ...
> 
> This prevents the gotox liveness tracking tests from being compiled and run
> on riscv64.
> 
> Should these architecture guards also be updated to ensure comprehensive test
> coverage for the newly introduced JIT feature on riscv64?
> 
> [ ... ]
> 

yah, should go with bpf_insn_array and compute_live_registers testcases