From: Eduard Zingerman <eddyz87@gmail.com>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>,
David Faust <david.faust@oracle.com>
Cc: "Jose E. Marchesi" <jose.marchesi@oracle.com>,
bpf <bpf@vger.kernel.org>,
James Hilliard <james.hilliard1@gmail.com>,
Nick Desaulniers <ndesaulniers@google.com>,
David Malcolm <dmalcolm@redhat.com>,
Julia Lawall <julia.lawall@inria.fr>,
elena.zannoni@oracle.com,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Yonghong Song <yhs@fb.com>, Mykola Lysenko <mykolal@fb.com>
Subject: Re: BTF tag support in DWARF (notes for today's BPF Office Hours)
Date: Wed, 22 Feb 2023 21:43:07 +0200 [thread overview]
Message-ID: <d6f9fe3faa4aef62227420fc41f2e896f4d7eb2a.camel@gmail.com> (raw)
In-Reply-To: <CAADnVQ+QNAEaqgOM9PwDs+0dkiL3wmPafJN=XY5ckcgTzmsiEg@mail.gmail.com>
On Wed, 2023-02-22 at 10:11 -0800, Alexei Starovoitov wrote:
[...]
> > > > What do you think about something like "debug_type_tag" or
> > > > "debug_type_annotation" (and a similar update for the decl tags)?
> > > > The translation into BTF records would be the same, but the DWARF info
> > > > would stand on its own without being tied to BTF.
> > > >
> > > > (Naming is a bit tricky since terms like 'tag' are already in use by
> > > > DWARF, e.g. "type tag" in the context of DWARF DIEs makes me think of
> > > > DW_TAG_xxxx_type...)
> > > >
> > > > As far as I understand, early proposals for the tags were more generic
> > > > but the LLVM reviewers wished for something more specific due to the
> > > > relatively limited use of the tags at the time. Now that the tags and
> > > > their DWARF format have matured I think a good case can be made to
> > > > make these generic. We'd be happy to help push for such change.
> > >
> > > On the other hand, BTF is a thing we are using this annotation for.
> > > Any other tool can reuse DW_TAG_LLVM_annotation, but it will need a
> > > way to distinguish it's annotations from BTF annotations. And this can
> > > be done by using a different DW_AT_name. So, it seems logical to
> > > retain "btf" in the DW_AT_name. What do you think?
> >
> > OK I can understand keeping it BTF specific.
> >
> > Other than that, I don't come up with any significantly different idea
> > than to use the ":v2" suffix, so let's go with "btf_type_tag:v2"?
>
> I don't like v2 suffix either.
> Please come up with something else.
Nothing particularly good comes to mind:
- btf_type_tag:wrapper
- btf_type_tag:outer
- btf_type_tag:own
- exterior_btf_type_tag
- outer_btf_tag
- btf_type_prefix
- btf_type_qualifier (as in const/volatile)
Or might as well use btf_type_tag:gcc, as you suggested earlier,
but it is as confusing as the others.
next prev parent reply other threads:[~2023-02-22 19:43 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-05 11:37 BTF tag support in DWARF (notes for today's BPF Office Hours) Jose E. Marchesi
2023-01-05 18:30 ` Jose E. Marchesi
2023-01-22 17:53 ` Yonghong Song
2023-01-23 15:50 ` Jose E. Marchesi
2023-01-23 18:43 ` David Faust
2023-01-24 7:37 ` Yonghong Song
2023-02-20 23:42 ` Eduard Zingerman
2023-02-21 19:38 ` David Faust
2023-02-21 22:57 ` Eduard Zingerman
2023-02-22 18:03 ` David Faust
2023-02-22 18:11 ` Alexei Starovoitov
2023-02-22 19:43 ` Eduard Zingerman [this message]
2023-02-27 21:13 ` Andrii Nakryiko
2023-02-28 0:41 ` Eduard Zingerman
2023-02-28 0:45 ` Andrii Nakryiko
2023-02-28 0:57 ` Eduard Zingerman
2023-02-28 2:44 ` Alexei Starovoitov
2023-02-28 5:28 ` Andrii Nakryiko
2023-02-28 6:53 ` Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6f9fe3faa4aef62227420fc41f2e896f4d7eb2a.camel@gmail.com \
--to=eddyz87@gmail.com \
--cc=acme@redhat.com \
--cc=alexei.starovoitov@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=david.faust@oracle.com \
--cc=dmalcolm@redhat.com \
--cc=elena.zannoni@oracle.com \
--cc=james.hilliard1@gmail.com \
--cc=jose.marchesi@oracle.com \
--cc=julia.lawall@inria.fr \
--cc=mykolal@fb.com \
--cc=ndesaulniers@google.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox