BPF List
 help / color / mirror / Atom feed
From: Ihor Solodrai <ihor.solodrai@linux.dev>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>, bpf@vger.kernel.org
Cc: daniel@iogearbox.net, andrii@kernel.org, eddyz87@gmail.com,
	memxor@gmail.com
Subject: Re: [PATCH bpf-next] selftests/bpf: Fix build of callx tests with GCC
Date: Thu, 24 Sep 2026 12:50:26 -0700	[thread overview]
Message-ID: <d9aa643c-438f-4658-a82c-f16b9ca944e3@linux.dev> (raw)
In-Reply-To: <20260924182104.261823-1-alexei.starovoitov@gmail.com>

On 9/24/26 11:21 AM, Alexei Starovoitov wrote:
> From: Alexei Starovoitov <ast@kernel.org>
> 
> GCC doesn't support indirect calls in BPF:
> 
>   progs/verifier_callx.c: In function 'apply_op':
>   progs/verifier_callx.c:977:1: error: indirect call in function, which are not supported by eBPF
>   progs/verifier_callx_rodata.c: In function 'use_shape':
>   progs/verifier_callx_rodata.c:746:1: error: indirect call in function, which are not supported by eBPF
> 
> Build verifier_callx, verifier_callx_rodata and callx_rodata progs
> with clang only. Skip callx_rodata_lskel test when progs are built
> with GCC.
> 
> Fixes: e9b22d50796d ("selftests/bpf: Add tests for callx")
> Fixes: b018e998e645 ("selftests/bpf: Add tests for callx through pointers in read-only data")
> Signed-off-by: Alexei Starovoitov <ast@kernel.org>

Tested-by: Ihor Solodrai <ihor.solodrai@linux.dev>

Confirmed the patch fixes the GCC BPF selftests build:
https://github.com/kernel-patches/vmtest/actions/runs/36043955840/job/107785910578

> ---
>  .../bpf/prog_tests/callx_rodata_lskel.c       |  6 ++++
>  .../selftests/bpf/progs/callx_rodata.c        | 28 +++++++++++++++++--
>  .../selftests/bpf/progs/verifier_callx.c      |  3 +-
>  .../bpf/progs/verifier_callx_rodata.c         |  3 +-
>  4 files changed, 36 insertions(+), 4 deletions(-)
> 
> [...]

  reply	other threads:[~2026-09-24 19:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-24 18:21 [PATCH bpf-next] selftests/bpf: Fix build of callx tests with GCC Alexei Starovoitov
2026-09-24 19:50 ` Ihor Solodrai [this message]
2026-09-24 20:00 ` patchwork-bot+netdevbpf
2026-09-25  6:50 ` Vineet Gupta
2026-09-25  6:50   ` Vineet Gupta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d9aa643c-438f-4658-a82c-f16b9ca944e3@linux.dev \
    --to=ihor.solodrai@linux.dev \
    --cc=alexei.starovoitov@gmail.com \
    --cc=andrii@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=eddyz87@gmail.com \
    --cc=memxor@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox