From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from out-173.mta0.migadu.com (out-173.mta0.migadu.com [91.218.175.173])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 16027182B4
	for <bpf@vger.kernel.org>; Tue,  8 Apr 2025 05:23:53 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.173
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1744089837; cv=none; b=NSD+g5/3y798Nwxi+6cSlID3W/IBsPXUe+/UvTHgBAQIK9bIloUwCZbC6KpQaF+LEY7JL1T6daDMvabFLlSFwRiDIA0gFXiPnISEOGPVS87CIKdOp6wC0YVaNidcRS7/ctzcOJaozO/w9O2IxUdWN/Eco7UxsG6rQ5DfbrgTdQU=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1744089837; c=relaxed/simple;
	bh=ImsvRoDAy2Ur9jItjKFW9euORH5r9NVFyr+isPigwOw=;
	h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:
	 In-Reply-To:Content-Type; b=F2aqhv5+yyVbz8d1r26we4glBXtmt8mihQF84Z8qC0pb80pTfRhhoApzcw7jEmxrd54ieBWMGhlX8Y9Hk3eQG3UI+mqjeru6MBTRkqWnbDWg1dT/Cd+MNqIcleJliRtSnSW62ZpaPMIuBbjYtqGwA0z8CJuq2KYYTVDGcnK1HXo=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=tCFgNK+0; arc=none smtp.client-ip=91.218.175.173
Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="tCFgNK+0"
Message-ID: <da0e43ef-4861-4541-951d-8d576fbaa069@linux.dev>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1;
	t=1744089831;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=F1laiUd4FjAcV7GBskzehdOpYcoxnge7IVbp62y0no8=;
	b=tCFgNK+0uEzi7nyqFmCSqGiNqqHwol7bsE03sP0+0yecnZWF+LaJPPzD9tsvB12XLR5fER
	hfz8Ol4Oubt2B9FrbHCRohBLBHd923Sv62w6b8/bilzh42hd4vP50ZZCq2S+PLcc9MDby8
	OaWNIogdWcxG8eSFq1I82o7e5dN71pM=
Date: Mon, 7 Apr 2025 22:23:47 -0700
Precedence: bulk
X-Mailing-List: bpf@vger.kernel.org
List-Id: <bpf.vger.kernel.org>
List-Subscribe: <mailto:bpf+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:bpf+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Subject: Re: [RFC PATCH bpf-next 2/3] bpf: udp: Avoid socket skips and repeats
 during iteration
To: Jordan Rife <jordan@jrife.io>
Cc: Kuniyuki Iwashima <kuniyu@amazon.com>, aditi.ghag@isovalent.com,
 bpf@vger.kernel.org, daniel@iogearbox.net, netdev@vger.kernel.org,
 willemdebruijn.kernel@gmail.com
References: <CABi4-ogLNdQw=gLTRZ4aJ8qiQWiovHaO19sx5uz29Es6du8GKg@mail.gmail.com>
 <20250408001649.5560-1-kuniyu@amazon.com>
 <CABi4-ogUtMrH8-NVB6W8Xg_F_KDLq=yy-yu-tKr2udXE2Mu1Lg@mail.gmail.com>
Content-Language: en-US
X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers.
From: Martin KaFai Lau <martin.lau@linux.dev>
In-Reply-To: <CABi4-ogUtMrH8-NVB6W8Xg_F_KDLq=yy-yu-tKr2udXE2Mu1Lg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Migadu-Flow: FLOW_OUT

On 4/7/25 7:39 PM, Jordan Rife wrote:
> 3) If vmalloc fails, propagate ENOMEM up to userspace and stop
> iteration instead of making the tradeoff of possibly repeating or
> skipping sockets. seq_read can already return ENOMEM in some cases, so
> IMO this feels more correct. WDYT?

Agree that this is better.
The stop() may need to take care of the start()/next() may fail. Take a look at 
the bpf_seq_read() in bpf_iter.c. Please check.