Re: [PATCH bpf-next v6 2/6] selftests/bpf: Add the traffic monitor option to test_progs.

Kui-Feng Lee
2024-08-08T20:23:39Z

On 8/8/24 12:44, Martin KaFai Lau wrote:
> On 8/7/24 11:31 AM, Kui-Feng Lee wrote:
>> +static bool should_tmon(struct test_selector *sel, int num, const
>> char *name)
>
> "int num" is not used. -m is name only, so not needed?

Right, it is not needed anymore.

>
>> +{
>> +    int i;
>> +
>> +    for (i = 0; i < sel->whitelist.cnt; i++) {
>> +        if (glob_match(name, sel->whitelist.tests[i].name) &&
>> +            !sel->whitelist.tests[i].subtest_cnt)
>> +            return true;
>> +    }
>> +
>> +    return false;
>> +}
>> +
>