Re: [EXT] [PATCH net-next v4 0/3] net: atlantic: Add XDP support

[Igor Russkikh <irusskikh@marvell.com>]

> v4:
>  - Fix compile warning
> 
> v3:
>  - Change wrong PPS performance result 40% -> 80% in single
>    core(Intel i3-12100)
>  - Separate aq_nic_map_xdp() from aq_nic_map_skb()
>  - Drop multi buffer packets if single buffer XDP is attached
>  - Disable LRO when single buffer XDP is attached
>  - Use xdp_get_{frame/buff}_len()

Hi Taehee, thanks for taking care of that!

Reviewed-by: Igor Russkikh <irusskikh@marvell.com>

A small notice about the selection of 3K packet size for XDP.
Its a kind of compromise I think, because with common 1.4K MTU we'll get wasted
2K bytes minimum per packet.

I was thinking it would be possible to reuse the existing page flipping technique
together with higher page_order, to keep default 2K fragment size.
E.g.
( 256(xdp_head)+2K(pkt frag) ) x 3 (flips) = ~7K

Meaning we can allocate 8K (page_order=1) pages, and fit three xdp packets into each, wasting only 1K per three packets.

But its just kind of an idea for future optimization.

Regards,
  Igor