From: Eduard Zingerman <eddyz87@gmail.com>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>, bpf@vger.kernel.org
Cc: daniel@iogearbox.net, andrii@kernel.org, martin.lau@kernel.org,
memxor@gmail.com, kernel-team@fb.com
Subject: Re: [PATCH v2 bpf-next 1/4] bpf: Relax tuple len requirement for sk helpers.
Date: Tue, 11 Jun 2024 13:31:17 -0700 [thread overview]
Message-ID: <db0ca9f4dcd146d56b350c28b0d26468b8c54b00.camel@gmail.com> (raw)
In-Reply-To: <20240610230849.80820-2-alexei.starovoitov@gmail.com>
On Mon, 2024-06-10 at 16:08 -0700, Alexei Starovoitov wrote:
> From: Alexei Starovoitov <ast@kernel.org>
>
> __bpf_skc_lookup() safely handles incorrect values of tuple len,
> hence we can allow zero to be passed as tuple len.
> This patch alone doesn't make an observable verifier difference.
> It's a trivial improvement that might simplify bpf programs.
>
> Signed-off-by: Alexei Starovoitov <ast@kernel.org>
> ---
All seems correct.
Acked-by: Eduard Zingerman <eddyz87@gmail.com>
next prev parent reply other threads:[~2024-06-11 20:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-10 23:08 [PATCH v2 bpf-next 0/4] bpf: Track delta between "linked" registers Alexei Starovoitov
2024-06-10 23:08 ` [PATCH v2 bpf-next 1/4] bpf: Relax tuple len requirement for sk helpers Alexei Starovoitov
2024-06-11 20:31 ` Eduard Zingerman [this message]
2024-06-10 23:08 ` [PATCH v2 bpf-next 2/4] bpf: Track delta between "linked" registers Alexei Starovoitov
2024-06-11 20:09 ` Eduard Zingerman
2024-06-12 15:52 ` Alexei Starovoitov
2024-06-10 23:08 ` [PATCH v2 bpf-next 3/4] bpf: Support can_loop/cond_break on big endian Alexei Starovoitov
2024-06-10 23:08 ` [PATCH v2 bpf-next 4/4] selftests/bpf: Add tests for add_const Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=db0ca9f4dcd146d56b350c28b0d26468b8c54b00.camel@gmail.com \
--to=eddyz87@gmail.com \
--cc=alexei.starovoitov@gmail.com \
--cc=andrii@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@fb.com \
--cc=martin.lau@kernel.org \
--cc=memxor@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox