From: Quentin Monnet <qmo@kernel.org>
To: Daniel Borkmann <daniel@iogearbox.net>,
Alexei Starovoitov <ast@kernel.org>,
Andrii Nakryiko <andrii@kernel.org>
Cc: Martin KaFai Lau <martin.lau@linux.dev>,
Eduard Zingerman <eddyz87@gmail.com>, Song Liu <song@kernel.org>,
Yonghong Song <yonghong.song@linux.dev>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>,
Stanislav Fomichev <sdf@fomichev.me>, Hao Luo <haoluo@google.com>,
Jiri Olsa <jolsa@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
bpf@vger.kernel.org
Subject: Re: [PATCH bpf-next] bpftool: Search for tracefs at /sys/kernel/tracing first
Date: Mon, 15 Sep 2025 12:47:04 +0100 [thread overview]
Message-ID: <db1f3718-f733-451b-9861-6ca45dc6edfb@kernel.org> (raw)
In-Reply-To: <055e1c7a-410f-4843-bec4-e545f032b145@iogearbox.net>
2025-09-15 13:33 UTC+0200 ~ Daniel Borkmann <daniel@iogearbox.net>
> On 9/12/25 12:43 PM, Quentin Monnet wrote:
> [...]
>> diff --git a/tools/bpf/bpftool/tracelog.c b/tools/bpf/bpftool/tracelog.c
>> index 31d806e3bdaa..49828a4f60c2 100644
>> --- a/tools/bpf/bpftool/tracelog.c
>> +++ b/tools/bpf/bpftool/tracelog.c
>> @@ -57,10 +57,8 @@ find_tracefs_mnt_single(unsigned long magic, char
>> *mnt, const char *mntpt)
>> static bool get_tracefs_pipe(char *mnt)
>> {
>> static const char * const known_mnts[] = {
>> - "/sys/kernel/debug/tracing",
>> "/sys/kernel/tracing",
>> - "/tracing",
>> - "/trace",
>> + "/sys/kernel/debug/tracing",
>> };
>> const char *pipe_name = "/trace_pipe";
>> const char *fstype = "tracefs";
>> @@ -96,11 +94,11 @@ static bool get_tracefs_pipe(char *mnt)
>> p_info("could not find tracefs, attempting to mount it now");
>> /* Most of the time, tracefs is automatically mounted by debugfs at
>> - * /sys/kernel/debug/tracing when we try to access it. If we
>> could not
>> + * /sys/kernel/tracing when we try to access it. If we could not
>> * find it, it is likely that debugfs is not mounted. Let's give
>> one
>
> nit: Should this comment be tweaked further, or maybe even removed
> completely
> given the now stale references to debugfs there?
Hi Daniel! Re-reading it, I realise my change for the comment is not
even correct, /sys/kernel/tracing is not mounted automatically. So yes,
I'll send a v2 to remove it. Thanks for the review!
Quentin
prev parent reply other threads:[~2025-09-15 11:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-12 10:43 [PATCH bpf-next] bpftool: Search for tracefs at /sys/kernel/tracing first Quentin Monnet
2025-09-15 11:33 ` Daniel Borkmann
2025-09-15 11:47 ` Quentin Monnet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=db1f3718-f733-451b-9861-6ca45dc6edfb@kernel.org \
--to=qmo@kernel.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=martin.lau@linux.dev \
--cc=rostedt@goodmis.org \
--cc=sdf@fomichev.me \
--cc=song@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox