From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C73AC07E95 for ; Sat, 10 Jul 2021 16:27:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7031561356 for ; Sat, 10 Jul 2021 16:27:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229506AbhGJQaO (ORCPT ); Sat, 10 Jul 2021 12:30:14 -0400 Received: from smtprelay0252.hostedemail.com ([216.40.44.252]:35202 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S229452AbhGJQaO (ORCPT ); Sat, 10 Jul 2021 12:30:14 -0400 Received: from omf12.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay07.hostedemail.com (Postfix) with ESMTP id 3C9BB181D3025; Sat, 10 Jul 2021 16:27:28 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by omf12.hostedemail.com (Postfix) with ESMTPA id 1F0D3240236; Sat, 10 Jul 2021 16:27:24 +0000 (UTC) Message-ID: Subject: Re: [PATCH -tip 6/6] kprobes: Use bool type for functions which returns boolean value From: Joe Perches To: Masami Hiramatsu , X86 ML , Ingo Molnar Cc: Steven Rostedt , Josh Poimboeuf , Daniel Xu , linux-kernel@vger.kernel.org, bpf@vger.kernel.org, kuba@kernel.org, mingo@redhat.com, ast@kernel.org, Thomas Gleixner , Borislav Petkov , Peter Zijlstra , kernel-team@fb.com, yhs@fb.com, linux-ia64@vger.kernel.org, Abhishek Sagar , Andrii Nakryiko Date: Sat, 10 Jul 2021 09:27:22 -0700 In-Reply-To: <162592897337.1158485.13933847832718343850.stgit@devnote2> References: <162592891873.1158485.768824457210707916.stgit@devnote2> <162592897337.1158485.13933847832718343850.stgit@devnote2> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.40.0-1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspamout05 X-Rspamd-Queue-Id: 1F0D3240236 X-Stat-Signature: g7d5ey6794yc3adwpqbjf4sfbzj4aa8s X-Session-Marker: 6A6F6540706572636865732E636F6D X-Session-ID: U2FsdGVkX18NhvQmIVgwou9EnrL7AsJoLwMB4STNfdM= X-HE-Tag: 1625934444-490807 Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Sat, 2021-07-10 at 23:56 +0900, Masami Hiramatsu wrote: > Use the 'bool' type instead of 'int' for the functions which > returns a boolean value, because this makes clear that those > functions don't return any error code. [] > diff --git a/include/linux/kprobes.h b/include/linux/kprobes.h [] > @@ -104,25 +104,25 @@ struct kprobe { >  #define KPROBE_FLAG_FTRACE 8 /* probe is using ftrace */ >   > >  /* Has this kprobe gone ? */ > -static inline int kprobe_gone(struct kprobe *p) > +static inline bool kprobe_gone(struct kprobe *p) >  { >   return p->flags & KPROBE_FLAG_GONE; >  } This change would also allow the removal of the !! from: kernel/trace/trace_kprobe.c:104: return !!(kprobe_gone(&tk->rp.kp)); --- kernel/trace/trace_kprobe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/trace/trace_kprobe.c b/kernel/trace/trace_kprobe.c index ea6178cb5e334..c6e0345a44e94 100644 --- a/kernel/trace/trace_kprobe.c +++ b/kernel/trace/trace_kprobe.c @@ -101,7 +101,7 @@ static nokprobe_inline unsigned long trace_kprobe_offset(struct trace_kprobe *tk static nokprobe_inline bool trace_kprobe_has_gone(struct trace_kprobe *tk) { - return !!(kprobe_gone(&tk->rp.kp)); + return kprobe_gone(&tk->rp.kp); } static nokprobe_inline bool trace_kprobe_within_module(struct trace_kprobe *tk,