BPF List
 help / color / mirror / Atom feed
From: Paolo Abeni <pabeni@redhat.com>
To: Suman Ghosh <sumang@marvell.com>,
	horms@kernel.org, sgoutham@marvell.com, gakula@marvell.com,
	sbhatta@marvell.com, hkelam@marvell.com, davem@davemloft.net,
	edumazet@google.com, kuba@kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, lcherian@marvell.com,
	jerinj@marvell.com, john.fastabend@gmail.com,
	bbhushan2@marvell.com, hawk@kernel.org, andrew+netdev@lunn.ch,
	ast@kernel.org, daniel@iogearbox.net, bpf@vger.kernel.org
Subject: Re: [net-next PATCH v3 2/6] octeontx2-pf: Add AF_XDP non-zero copy support
Date: Tue, 14 Jan 2025 13:39:27 +0100	[thread overview]
Message-ID: <dddca9a4-9ee3-4da1-b68d-26f208566d5d@redhat.com> (raw)
In-Reply-To: <20250110093807.2451954-3-sumang@marvell.com>

On 1/10/25 10:38 AM, Suman Ghosh wrote:
> For XDP, page_pool APIs are getting used now. But the memory type was
> not getting set due to which XDP_REDIRECT and hence AF_XDP was not
> working. This patch ads the memory type MEM_TYPE_PAGE_POOL as the memory
> model of the XDP program.
> 
> Signed-off-by: Suman Ghosh <sumang@marvell.com>

This looks like a fixes that deserve its own fix tag and likely going
trough the 'net' tree.

I think you can still include in a net-next series to simplify the
merging, but the fix tag should be added anyway.

> diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c
> index 2859f397f99e..730f2b7742db 100644
> --- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c
> +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c
> @@ -96,7 +96,7 @@ static unsigned int frag_num(unsigned int i)
>  
>  static void otx2_xdp_snd_pkt_handler(struct otx2_nic *pfvf,
>  				     struct otx2_snd_queue *sq,
> -				 struct nix_cqe_tx_s *cqe)
> +				     struct nix_cqe_tx_s *cqe)
>  {
>  	struct nix_send_comp_s *snd_comp = &cqe->comp;
>  	struct sg_list *sg;

For the same reasons, please move the white-space changes to a later patch.

Thanks,

Paolo


  reply	other threads:[~2025-01-14 12:39 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-10  9:38 [net-next PATCH v3 0/6] Add af_xdp support for cn10k Suman Ghosh
2025-01-10  9:38 ` [net-next PATCH v3 1/6] octeontx2-pf: Don't unmap page pool buffer used by XDP Suman Ghosh
2025-01-14 12:44   ` Paolo Abeni
2025-01-15 18:29     ` [EXTERNAL] " Suman Ghosh
2025-01-10  9:38 ` [net-next PATCH v3 2/6] octeontx2-pf: Add AF_XDP non-zero copy support Suman Ghosh
2025-01-14 12:39   ` Paolo Abeni [this message]
2025-01-15 18:27     ` [EXTERNAL] " Suman Ghosh
2025-01-10  9:38 ` [net-next PATCH v3 3/6] octeontx2-pf: AF_XDP zero copy receive support Suman Ghosh
2025-01-14 12:46   ` Paolo Abeni
2025-01-15 18:31     ` [EXTERNAL] " Suman Ghosh
2025-01-10  9:38 ` [net-next PATCH v3 4/6] octeontx2-pf: Reconfigure RSS table after enabling AF_XDP zerocopy on rx queue Suman Ghosh
2025-01-10  9:38 ` [net-next PATCH v3 5/6] Octeontx2-pf: Prepare for AF_XDP Suman Ghosh
2025-01-10  9:38 ` [net-next PATCH v3 6/6] octeontx2-pf: AF_XDP zero copy transmit support Suman Ghosh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dddca9a4-9ee3-4da1-b68d-26f208566d5d@redhat.com \
    --to=pabeni@redhat.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=ast@kernel.org \
    --cc=bbhushan2@marvell.com \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=gakula@marvell.com \
    --cc=hawk@kernel.org \
    --cc=hkelam@marvell.com \
    --cc=horms@kernel.org \
    --cc=jerinj@marvell.com \
    --cc=john.fastabend@gmail.com \
    --cc=kuba@kernel.org \
    --cc=lcherian@marvell.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=sbhatta@marvell.com \
    --cc=sgoutham@marvell.com \
    --cc=sumang@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox