From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF9E64F5E1A for ; Mon, 19 Oct 2026 13:40:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792417217; cv=none; b=T8HUtTvUM7GlBEKGIdIZodBrGTOwpj0ksK6+UFkZmvlwGTqQr9ElDPFEThCmD0IY9X76yw+lZlHcaDtp5sNL5Sj452fu0nEavBxHKmFVplM8+AlqrFw+mJ6M6QX7QcBbjAiAnhvIuxZYF5KCV6GD/BrXw+l/KVaYTKJfsarrel8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792417217; c=relaxed/simple; bh=wZv3qit3PqVwPOCxbvA9JQOzFYusdtSCHyQzH3LGaxQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=CEBh33CZ5l6hQqd5cMHK+em8OE1l+REiYZiHB4peYI68/aiBwkNTaILosHmwUx9FdFbeaMESjzmXjovKJvj75Gq3vANjq1mkHo1TJX/gec/Z0GE4XheD8+IrLU3gCaxw98a5srZSPgDJEM5K+04TRoUV5wSU+L8Nx5YEHGtVd30= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=EFFLiUGD; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=KCqandS4; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="EFFLiUGD"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="KCqandS4" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1792417214; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zzIEK6Y3mdF98EhIAvT8i3Drct8km1nTgvw7YT+e73M=; b=EFFLiUGD4zv6O0+VG9p3H3uk1VhqYPC7xgb1C37CRCnBsmYsBQOcOF42w02+yrjJs8dILX bfAh5vqX5DjWol7pjEFSfoAMeSx0Pz8TtXwkgBDo+XWc+Wi7/o/jgSZ26VE3LP9noWABwc 2ZS/dQrN8tuws7pJka0UTwWg0o8pweI= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-367-jyIf_4VoN5mOp8HaLTUqYQ-1; Mon, 19 Oct 2026 13:40:07 +0000 X-MC-Unique: jyIf_4VoN5mOp8HaLTUqYQ-1 X-Mimecast-MFC-AGG-ID: jyIf_4VoN5mOp8HaLTUqYQ_1792417206 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-48e17d30a79so597668f8f.3 for ; Mon, 19 Oct 2026 06:40:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1792417206; x=1793022006; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=zzIEK6Y3mdF98EhIAvT8i3Drct8km1nTgvw7YT+e73M=; b=KCqandS4MNYZHpEpTmowN+qdQLF1xtP/5bsTOX/MNIG8mzF5KqY8fZCtUizWr/8Jlz V6KL2LIs7UR0LEKdSxHel2LzjZqfsCz7U7wQjYO/L+hhF/IxPiEfnn0xQEAR6I8Ekx68 B2mjAVXbdeeY5MS+gS5o7ISU4+ZSgwbKUYmiCjZdhkerotOk0zJFNatQWjrQLu2h80x+ +u2PpLx1G953NPtDkyHvJtiAfvr6ENcmviaiQa0Wv/6IgCw72h9DzOau+ofaxaJ6wv3n UMdi7dD/I51+ndjRPMXnqGcEaIGgbvL91JvaQ4XnENPoEMb9VALI4r9ZECHLugEJLXO7 MC9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792417206; x=1793022006; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=zzIEK6Y3mdF98EhIAvT8i3Drct8km1nTgvw7YT+e73M=; b=ZNnKL/kRFklR9ePlWsAuBGc4ib554LmTqn46oof+9Z08ZhURMzc8rteX7qObxdgILi ezuYt0gjzMKIvI0omi/oT/uRPzQf0wzHBaL1OD/1XjZlHTm8oYz4ugF17VpN4N1JvT8J zs/kBMImoW8K+ahUbw3cgj55y2SjTXo5VIH6zJLpYfi9U/L/yS/vSugTOoA/MQugF7SL bJIbGAK0D4BM4ZDD469qvsoaFZsFBRN97G3jMg0o4lOaFyMtsrcQCacDt+2jYSG/YEsw TRbO4KzpFVvSRNot+ZWj7PqCl3YLggYPJKcpcQLpKkNjn64lxsshvBH3BYkKgacdTcns HSUQ== X-Forwarded-Encrypted: i=1; AKwUvBxhtebuNsKT0BT0hmBYBKebq5G8fVt/YF46uRiLTRaEc4W42kyo2QBJUDNyY1kwX3LYPsE=@vger.kernel.org X-Gm-Message-State: AFq9FYIG0eB+pudm5x7fosRS05ObrKiaz/3RVeXm/PoFeeGWGb+JKNJA XVxaeIf2lm0jZeykobOB7G8aRbAkdtRcs3zmdpjReVLMajaEypGH9tUy6VQ4F/O/Nh59g6M9Awv qUSf6MC9jxSns3hJZ93F6xTZkeaP9z7C/PV0mkRzxG+aFSd6QlK7QsA== X-Gm-Gg: AYBFou1vCn9ZLTlv2iHyIyucDpLtKQ0pZ/WHKtQRR+3DRY6H4Pql6301Iboh0IZzEoC G7/O2ZYsCQSCOFOpgkFSliJXes6EvOHB+Atl1S6YG3GEYcF2PDlIhEMOWAEot8M6Saj9dXuJXJd 0v0B7pPBlT0hxB7z/sFtcLwWk6Fb48e7o2eJGqSaWwgA8fMSROvMoRwBdkodtM5mihcw5Tkj8/t UIn5EQ9wAAQiIi6YyQCY7iksRu4i27tUv0UBkAFrj+J8hR62wqWYMOysjUL6jDOT5X+qM00A/gL w4d9m8jdsdon1iy4fSgw3tHkUuDd/J+kCUKiYiblZSLEEUmLl5NOlcg6/bvHZ8BAXFOPyF2oxIv m2On2OKhGKEOJqMDNkN4QO/Rb6wNRMIFNvtqHAV9eTxgkCbZ2ss+wzXpSoX2x+qEKew/3WVZxNA == X-Received: by 2002:a05:600c:19d2:b0:4a1:d10c:7170 with SMTP id 5b1f17b1804b1-4a1d76262e1mr160994265e9.31.1792417204814; Mon, 19 Oct 2026 06:40:04 -0700 (PDT) X-Received: by 2002:a05:600c:19d2:b0:4a1:d10c:7170 with SMTP id 5b1f17b1804b1-4a1d76262e1mr160991705e9.31.1792417202770; Mon, 19 Oct 2026 06:40:02 -0700 (PDT) Received: from [192.168.188.234] (ip232-47-231-195.pool-bba.aruba.it. [195.231.47.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4a1dc8ee409sm292224555e9.13.2026.10.19.06.40.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Oct 2026 06:40:01 -0700 (PDT) Message-ID: Date: Mon, 19 Oct 2026 15:40:00 +0200 Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next 2/2] net: stmmac: disable TX checksum offload for jumbo frames on bugged cores To: Lorenzo Bianconi , netdev-bot+sashiko@kernel.org Cc: maxime.chevallier@bootlin.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@kernel.org, kuba@kernel.org, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, ast@kernel.org, daniel@iogearbox.net, hawk@kernel.org, john.fastabend@gmail.com, sdf@fomichev.me, boon.leong.ong@intel.com, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, bpf@vger.kernel.org References: <20261012-stmmac-xdp-tx-pre-fixes-v1-2-05fd0c90f7e1@oss.qualcomm.com> <179190522792.434549.2113659711683261245@kernel.org> Content-Language: en-US From: Paolo Abeni In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 10/13/26 17:33, Lorenzo Bianconi wrote: >> Thank you for your contribution! Sashiko AI review found more severe >> issue(s) in other patches of this series. This mail is only an FYI, in case >> you want to address the nit picks below when you respin. >> >> Low priority / nit picks for your consideration: >> >> - [Low] The commit message's premise doesn't match the tree. >> >> Pre-existing issues: >> - [Medium] This problem wasn't introduced by this patch, but >> stmmac_xdp_xmit_xdpf() never looks at priv->plat->tx_coe when deciding… >> >> -- >> >> net: stmmac: disable TX checksum offload for jumbo frames on bugged cores >> >> This patch turns off TX checksum insertion in stmmac_xdp_xmit_xdpf() for >> frames longer than ETH_FRAME_LEN on bugged_jumbo cores. It is meant to >> match the stmmac_fix_features() workaround that the skb path already uses. >> >>> The XDP TX >>> path bypasses that workaround, so once XDP is allowed at MTU > >>> ETH_DATA_LEN, jumbo frames sent via XDP_TX or redirected into the >>> device would leave the interface with a full checksum insertion enabled >>> on those cores - exactly what the workaround is meant to avoid. >> >> [Severity: Low] >> Can this scenario happen in the current tree? XDP still can't be used with >> a jumbo MTU. stmmac_xdp_set_prog() refuses to attach a program when the MTU >> is above ETH_DATA_LEN: > > This is actually a preliminary fix needed to remove the MTU limitation when the > device is running in XDP mode. The point is that this patch does not address any issues, no it should not include a fixes tag. I'll drop it while applying the series. Also a more explicative cover letter would have helped. No need to repost. Thanks, Paolo