From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FDB0C433EF for ; Mon, 28 Feb 2022 15:53:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233380AbiB1Pyc (ORCPT ); Mon, 28 Feb 2022 10:54:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57924 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237667AbiB1Pyb (ORCPT ); Mon, 28 Feb 2022 10:54:31 -0500 Received: from www62.your-server.de (www62.your-server.de [213.133.104.62]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AB97E11A1E; Mon, 28 Feb 2022 07:53:52 -0800 (PST) Received: from sslproxy02.your-server.de ([78.47.166.47]) by www62.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92.3) (envelope-from ) id 1nOiLJ-000F04-J5; Mon, 28 Feb 2022 16:53:45 +0100 Received: from [85.1.206.226] (helo=linux.home) by sslproxy02.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nOiLJ-0000ts-3v; Mon, 28 Feb 2022 16:53:45 +0100 Subject: Re: [PATCH v2 sysctl-next] bpf: move the bpf syscall sysctl table to bpf module To: Yan Zhu , mcgrof@kernel.org Cc: andrii@kernel.org, ast@kernel.org, bpf@vger.kernel.org, john.fastabend@gmail.com, kafai@fb.com, keescook@chromium.org, kpsingh@kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, liucheng32@huawei.com, netdev@vger.kernel.org, nixiaoming@huawei.com, songliubraving@fb.com, xiechengliang1@huawei.com, yhs@fb.com, yzaikin@google.com, zengweilin@huawei.com References: <20220223102808.80846-1-zhuyan34@huawei.com> From: Daniel Borkmann Message-ID: Date: Mon, 28 Feb 2022 16:53:44 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <20220223102808.80846-1-zhuyan34@huawei.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Authenticated-Sender: daniel@iogearbox.net X-Virus-Scanned: Clear (ClamAV 0.103.5/26467/Mon Feb 28 10:24:05 2022) Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org Hi Yan, On 2/23/22 11:28 AM, Yan Zhu wrote: > Aggregating the code of the feature in the code file of the feature > itself can improve readability and reduce merge conflicts. So move > the bpf syscall sysctl table to kernel/bpf/syscall.c > > Signed-off-by: Yan Zhu > > --- > v1->v2: > 1.Added patch branch identifier sysctl-next. > 2.Re-describe the reason for the patch submission. I'm not applying it given there is very little value in this change, see also what has been said earlier: https://lore.kernel.org/bpf/CAADnVQKmBoQEG1+nmrCg2ePVncn9rZJX9R4eucP9ULiY=xVGjQ@mail.gmail.com/ Thanks, Daniel