From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 64F761E9B35 for ; Sat, 21 Dec 2024 07:23:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734765819; cv=none; b=T9sJXuogjrsZy9bg34yGXMivZd2WJZeG/Oy/yymDaOhtTb0/IjcUeSRGGBjJ45eRt8CXpcSTfNUkPnLKKSXCx6wjeJ57bJ/s0b3RcyWERlWs7zyaLRoBvCBjluRFtJS/GzeA+K3tY+nuf5cJs1DBnOUYds206YchOATPWCxLR9E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734765819; c=relaxed/simple; bh=aqb8+RHJ6WxTEsAzfR/cFGlypEucYWaD7igL/fV/Qgw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ICbcHUAkPAxO3fvdSGzpqTzyqxf2MSdC2Ptu9QdBrHkmXEuIy0L+8UAGE6FmSYxWUFne+piuJGGbfMjuIJnfmTuA9o5Q8d/65i/zEmVUrjN4dvyGjbXgNDzPPfrbsp2YOP3aFjyZa4MtGmpSHTi0GZj6W1JRZtKVF7EXoDqveH8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=blackwall.org; spf=none smtp.mailfrom=blackwall.org; dkim=pass (2048-bit key) header.d=blackwall-org.20230601.gappssmtp.com header.i=@blackwall-org.20230601.gappssmtp.com header.b=YBvk2BXs; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=blackwall.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=blackwall.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=blackwall-org.20230601.gappssmtp.com header.i=@blackwall-org.20230601.gappssmtp.com header.b="YBvk2BXs" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4361b6f9faeso16518015e9.1 for ; Fri, 20 Dec 2024 23:23:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=blackwall-org.20230601.gappssmtp.com; s=20230601; t=1734765816; x=1735370616; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=L9mtmPZIi+Kyt6bE6scI5p+7PdJbZWOLUW810rPO8q4=; b=YBvk2BXsFvMSBVA6BY8dpzRv82OYXAWvZcB76EKcCSjb1WvS7MN/D1MoJoCzIFMkVU j1W9TBqCa7ewtspHMKvKYhnFGgMEo7EzSpJ6FogRcHkvabXzUX3HROgYkM2QDtvtEtjJ YXC5jVlMLucKmeNXfbr6JR1p49Nzn6HcxnX6Th6eMKKn+qeKsOjVmfIqAf7m/sNOgbAP EajR3CAE219NV9JaN6HBO5ejajS3bKQATpAug3BPDw7jVx7MetxNpJj7GZMQ9+JeOUfu luH9pcPN2NfC6a8EZwownK0DMtKztTbwZPuOS0fc09X3s2AvyETA7s8YAVom+xgDPOkj G7Kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734765816; x=1735370616; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=L9mtmPZIi+Kyt6bE6scI5p+7PdJbZWOLUW810rPO8q4=; b=iyhW3xoYvzkGjHIytt9YVUov5BZPXhGZMrC2NFh2l2r5+27mduyJw7887lbPR2aXOH C0OvUSs9PldNywGBy7QjsRAZnEBFTnuewAVzgAq8AJwzYnxlUtfui5MlavzUtZt/jSLm 0MIgjQC/TG8BSxlsVvAaIKjUCZYVRJp5BzYINU8B4PxTUZ8uqfMqbj0eIgfH/69wUhhY ++TUHxK6nrJyuvjrV96p3Yuh32pw/kxdVGI4L4TaF59fjez3PuX33rDDFl51RB3Pxh+z WsxbzxHU4IT3UB1tEJh9igiK7OvCyXrR83Rk4HgeTyqWQCA4Kgu6PCR65NJmSAKlMVct A3RQ== X-Forwarded-Encrypted: i=1; AJvYcCVJqy/hH8N3q6u4TUQCjoTLBLwf6u1HxFZBuJJgaxd13M0nZnGCcpRVM7kzAuuTawUifhc=@vger.kernel.org X-Gm-Message-State: AOJu0YzYne5G5ykvaPeZYWQn5+C8rcVq0tAsT83AGAYNuyqELXkhiC3o Yj3y8415l35+q6NowywizbJKQUKoxayLQ3Kb8R7slB7ZvXNpd8AhNunK6IkWy48= X-Gm-Gg: ASbGncs2p85YUvaErJAvm77xxjdGs3XBnSKxUgHoTqYWrvkgsgZC6wKW1tgjyTFMhMg T5gCazL8/5pIU/13fisaWyRruGz7TyWWHP1Qsufs9mXRTXQ8KQE7x9U7sCNrHbCMeGVknKwhozQ pig/hHIThHijNxL11C5WdDNhqFX5FyQpEczXh/nV/5g0H2TBDFnk/D9vnjOK541s/RPx/HW5QgT Ef0hmzI4GKsOul6teRYxX/mLQG1Wg8kDsBkFY+W4oLL5BnbAQUIBEsjyUj0+bOCHXHXyN7xr45v sbnIDxW52Zms X-Google-Smtp-Source: AGHT+IFzR+b0dJ8cXMxJaFZxa/uj8LNvR4GrBhtZTQrt4Y4gAjYydHlqcDBVhcZM8706zr0B7e7dvQ== X-Received: by 2002:a05:600c:1c02:b0:434:f2af:6e74 with SMTP id 5b1f17b1804b1-43669a28ea7mr46560595e9.15.1734765815604; Fri, 20 Dec 2024 23:23:35 -0800 (PST) Received: from [192.168.0.123] (78-154-15-142.ip.btc-net.bg. [78.154.15.142]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-436611ea3d5sm68529405e9.5.2024.12.20.23.23.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 Dec 2024 23:23:35 -0800 (PST) Message-ID: Date: Sat, 21 Dec 2024 09:23:34 +0200 Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH bpf-next v2 1/3] netkit: Allow for configuring needed_{head,tail}room To: Daniel Borkmann , martin.lau@linux.dev Cc: pabeni@redhat.com, kuba@kernel.org, bpf@vger.kernel.org, netdev@vger.kernel.org References: <20241220234658.490686-1-daniel@iogearbox.net> Content-Language: en-US From: Nikolay Aleksandrov In-Reply-To: <20241220234658.490686-1-daniel@iogearbox.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 12/21/24 01:46, Daniel Borkmann wrote: > Allow the user to configure needed_{head,tail}room for both netkit > devices. The idea is similar to 163e529200af ("veth: implement > ndo_set_rx_headroom") with the difference that the two parameters > can be specified upon device creation. By default the current behavior > stays as is which is needed_{head,tail}room is 0. > > In case of Cilium, for example, the netkit devices are not enslaved > into a bridge or openvswitch device (rather, BPF-based redirection > is used out of tcx), and as such these parameters are not propagated > into the Pod's netns via peer device. > > Given Cilium can run in vxlan/geneve tunneling mode (needed_headroom) > and/or be used in combination with WireGuard (needed_{head,tail}room), > allow the Cilium CNI plugin to specify these two upon netkit device > creation. > > Signed-off-by: Daniel Borkmann > Cc: Paolo Abeni > Cc: Nikolay Aleksandrov > --- > v2: > - static struct (Jakub) > > drivers/net/netkit.c | 66 +++++++++++++++++++----------- > include/uapi/linux/if_link.h | 2 + > tools/include/uapi/linux/if_link.h | 2 + > 3 files changed, 47 insertions(+), 23 deletions(-) > need coffee, just acked v1 and was looking at v2.. Acked-by: Nikolay Aleksandrov