From: Quentin Monnet <qmo@kernel.org>
To: Andrii Nakryiko <andrii@kernel.org>,
bpf@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net,
martin.lau@kernel.org
Cc: alan.maguire@oracle.com, eddyz87@gmail.com, jolsa@kernel.org
Subject: Re: [PATCH v2 bpf-next 4/5] bpftool: use BTF field iterator in btfgen
Date: Wed, 5 Jun 2024 09:45:38 +0100 [thread overview]
Message-ID: <e14d2461-7336-43e4-88c3-b0a6abac4bab@kernel.org> (raw)
In-Reply-To: <20240605001629.4061937-5-andrii@kernel.org>
2024-06-05 01:16 UTC+0100 ~ Andrii Nakryiko <andrii@kernel.org>
> Switch bpftool's code which is using libbpf-internal
> btf_type_visit_type_ids() helper to new btf_field_iter functionality.
>
> This makes bpftool code simpler, but also unblocks removing libbpf's
> btf_type_visit_type_ids() helper completely.
>
> Acked-by: Eduard Zingerman <eddyz87@gmail.com>
> Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
Still looks good to me :)
Reviewed-by: Quentin Monnet <qmo@kernel.org>
next prev parent reply other threads:[~2024-06-05 8:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-05 0:16 [PATCH v2 bpf-next 0/5] libbpf: BTF field iterator Andrii Nakryiko
2024-06-05 0:16 ` [PATCH v2 bpf-next 1/5] libbpf: add " Andrii Nakryiko
2024-06-05 0:16 ` [PATCH v2 bpf-next 2/5] libbpf: make use of BTF field iterator in BPF linker code Andrii Nakryiko
2024-06-05 0:16 ` [PATCH v2 bpf-next 3/5] libbpf: make use of BTF field iterator in BTF handling code Andrii Nakryiko
2024-06-05 0:16 ` [PATCH v2 bpf-next 4/5] bpftool: use BTF field iterator in btfgen Andrii Nakryiko
2024-06-05 8:45 ` Quentin Monnet [this message]
2024-06-05 0:16 ` [PATCH v2 bpf-next 5/5] libbpf: remove callback-based type/string BTF field visitor helpers Andrii Nakryiko
2024-06-05 8:52 ` [PATCH v2 bpf-next 0/5] libbpf: BTF field iterator Jiri Olsa
2024-06-05 14:48 ` Alan Maguire
2024-06-05 15:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e14d2461-7336-43e4-88c3-b0a6abac4bab@kernel.org \
--to=qmo@kernel.org \
--cc=alan.maguire@oracle.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=jolsa@kernel.org \
--cc=martin.lau@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox