From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E107C433EF for ; Wed, 13 Jul 2022 13:57:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236243AbiGMN5R (ORCPT ); Wed, 13 Jul 2022 09:57:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60286 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230520AbiGMN5Q (ORCPT ); Wed, 13 Jul 2022 09:57:16 -0400 Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E959D2CE20 for ; Wed, 13 Jul 2022 06:57:15 -0700 (PDT) Received: by mail-wm1-x329.google.com with SMTP id n185so6557529wmn.4 for ; Wed, 13 Jul 2022 06:57:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=isovalent-com.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=kxqBWdiXM5WNeClMPGN89m5g9fK7yBoXSaVViiNVQ8g=; b=g7sCyBZ237J9K19/0sLWl+a9stt/xgvJwPjoGXhb1JnLwI9WgOT5UER5tZx+ucO7HG TUidhRNoQx+iPvX8Cgu5YLiKO+LQiydCKckRhJpvZ3WLOOvGGvPFEdLoR27DGwu4V6FC zIkvixE0WB/haEqVW38dd4zgrBNkJ999UIgBDvj/EELkdCw9TTP2uxxC/AvujWJGOgkL Wa0VFTm0j38hB0F08Z+72EJ9vjPAazAJ0OZ27HkdmdS/UrumBa6DjT7TOHxKNfhNd77N c0IJDm7qvKme7P5/5iNKwpPqgpF4gdnSBFULZkFpjmRuC1ToMJxx3gDnMCXaxFwyYjma rxWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=kxqBWdiXM5WNeClMPGN89m5g9fK7yBoXSaVViiNVQ8g=; b=pDX4S4wMTiiFBcVXQPwr0W39Gz35C02MNZwtIZYLzXlIcGTnuMUM/SJ8UWWvhpD7ky WSCLfnFlbC3jJuqhZIULJVGDOnKNlhV3YdnF7AshDvVU2ourZjTUroQQ1kGUjPsIEgiO 4bNVJA+dHf+N+RFwQHXs4yvM5JoB2skpV0A1SwktmoqGOIFHi21g9hngvwpTyJJmFHuV 53y7UxfZjdvv7+on0dRWmkqB3zJu25BEwmZbBPpcvbE1PYmahcCE77KAGURR/Ghysypj ke6iz2a66WZw7ErL+2AZVx8Uv3eO/zRy2Wq+ovKjCTA+/PfsR7YoyA/dcEDWYTcYluxY AHrA== X-Gm-Message-State: AJIora/IRAdxm++Be4ZAS4WwFOWYX+Hc+AlsyNkjo8iS3ur9vGcIwE2C vskUE+57BleP4dF+R1AxcYi+5A== X-Google-Smtp-Source: AGRyM1uyOfqclVmQuJNbbQ1yXc9HRCf/RwP0I+Sf1skoemahVccck27LpxY8u85oblBG8emnTLxgjQ== X-Received: by 2002:a05:600c:2117:b0:3a2:d44f:4d9f with SMTP id u23-20020a05600c211700b003a2d44f4d9fmr9634057wml.17.1657720634459; Wed, 13 Jul 2022 06:57:14 -0700 (PDT) Received: from [192.168.178.32] ([51.155.200.13]) by smtp.gmail.com with ESMTPSA id z11-20020a5d4d0b000000b0021b9f126fd3sm10946839wrt.14.2022.07.13.06.57.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 Jul 2022 06:57:14 -0700 (PDT) Message-ID: Date: Wed, 13 Jul 2022 14:57:13 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.0.2 Subject: Re: [RFC PATCH v2 1/1] bpftool: Align dumped file headers with skeletons. Content-Language: en-GB To: Francis Laniel , bpf@vger.kernel.org Cc: Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , open list References: <20220713134046.15020-1-flaniel@linux.microsoft.com> <20220713134046.15020-2-flaniel@linux.microsoft.com> From: Quentin Monnet In-Reply-To: <20220713134046.15020-2-flaniel@linux.microsoft.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On 13/07/2022 14:40, Francis Laniel wrote: > This commit adds the following lines to file generated by dump: > /* SPDX-License-Identifier: (LGPL-2.1 OR BSD-2-Clause) */ > /* THIS FILE IS AUTOGENERATED BY BPFTOOL! */ > Hence, the dumped file headers follows that of skeletons. > > Signed-off-by: Francis Laniel > --- > tools/bpf/bpftool/btf.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tools/bpf/bpftool/btf.c b/tools/bpf/bpftool/btf.c > index 7e6accb9d9f7..066a0acd0ecd 100644 > --- a/tools/bpf/bpftool/btf.c > +++ b/tools/bpf/bpftool/btf.c > @@ -425,6 +425,8 @@ static int dump_btf_c(const struct btf *btf, > if (err) > return err; > > + printf("/* SPDX-License-Identifier: (LGPL-2.1 OR BSD-2-Clause) */\n"); > + printf("/* THIS FILE IS AUTOGENERATED BY BPFTOOL! */\n"); > printf("#ifndef __VMLINUX_H__\n"); > printf("#define __VMLINUX_H__\n"); > printf("\n"); Looks good, simpler than v1, thank you! Reviewed-by: Quentin Monnet