From: Eduard Zingerman <eddyz87@gmail.com>
To: Shardul Bankar <shardulsb08@gmail.com>, bpf@vger.kernel.org
Cc: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Martin KaFai Lau <martin.lau@linux.dev>,
Song Liu <song@kernel.org>,
Yonghong Song <yonghong.song@linux.dev>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>,
Stanislav Fomichev <sdf@fomichev.me>,
Hao Luo <haoluo@google.com>, Jiri Olsa <jolsa@kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 bpf] bpf: liveness: clarify get_outer_instance() handling in propagate_to_outer_instance()
Date: Tue, 21 Oct 2025 08:57:47 -0700 [thread overview]
Message-ID: <e2716ad9963403dd0dea37c85d106267659e52bd.camel@gmail.com> (raw)
In-Reply-To: <20251021080849.860072-1-shardulsb08@gmail.com>
On Tue, 2025-10-21 at 13:38 +0530, Shardul Bankar wrote:
> propagate_to_outer_instance() calls get_outer_instance() and uses the
> returned pointer to reset and commit stack write marks. Under normal
> conditions, update_instance() guarantees that an outer instance exists,
> so get_outer_instance() cannot return an ERR_PTR.
>
> However, explicitly checking for IS_ERR(outer_instance) makes this code
> more robust and self-documenting. It reduces cognitive load when reading
> the control flow and silences potential false-positive reports from
> static analysis or automated tooling.
>
> No functional change intended.
>
> Reported-by: kernel-patches-review-bot (https://github.com/kernel-patches/bpf/pull/10006#issuecomment-3409419240)
> Suggested-by: Eduard Zingerman <eddyz87@gmail.com>
> Signed-off-by: Shardul Bankar <shardulsb08@gmail.com>
> ---
Acked-by: Eduard Zingerman <eddyz87@gmail.com>
next prev parent reply other threads:[~2025-10-21 15:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-21 8:08 [PATCH v3 bpf] bpf: liveness: clarify get_outer_instance() handling in propagate_to_outer_instance() Shardul Bankar
2025-10-21 15:57 ` Eduard Zingerman [this message]
2025-10-21 16:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e2716ad9963403dd0dea37c85d106267659e52bd.camel@gmail.com \
--to=eddyz87@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=sdf@fomichev.me \
--cc=shardulsb08@gmail.com \
--cc=song@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox