From: Leon Hwang <hffilwlqm@gmail.com>
To: Kumar Kartikeya Dwivedi <memxor@gmail.com>
Cc: bpf@vger.kernel.org, Alexei Starovoitov <ast@kernel.org>,
Andrii Nakryiko <andrii@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Martin KaFai Lau <martin.lau@kernel.org>,
Eduard Zingerman <eddyz87@gmail.com>,
Ihor Solodrai <ihor.solodrai@linux.dev>,
kkd@meta.com, kernel-team@meta.com
Subject: Re: [PATCH bpf-next v2 0/6] Add support to emit verifier warnings
Date: Mon, 20 Apr 2026 13:45:23 +0800 [thread overview]
Message-ID: <e3e40b8b-9fff-4cb0-869e-fcaeb6b307ac@gmail.com> (raw)
In-Reply-To: <CAP01T76wkwaXSmLpAS3GtK4VKELzgkeYxozcxFav+C1F7LTYTg@mail.gmail.com>
On 18/4/26 19:06, Kumar Kartikeya Dwivedi wrote:
> On Wed, 8 Apr 2026 at 16:30, Leon Hwang <hffilwlqm@gmail.com> wrote:
>>
>> On 2026/4/8 22:55, Leon Hwang wrote:
>>>
[...]
>>>
>>> Since I'm going to add common attributes [1] support for BPF syscall,
>>> how about reporting the warnings via the common attributes? Even though,
>>> the original intent of common attributes support for BPF_LOAD was
>> BPF_LOAD -> BPF_PROG_LOAD
>>
>> Also, common attributes support for BPF_BTF_LOAD was to report logs,
>> similar to btf_log_* in union bpf_attr.
>>
>> If to report the warnings via common attributes for BPF_PROG_LOAD, we
>> should rethink the purpose of common attributes support for BPF_BTF_LOAD.
>>
>>> report the verifier log too.
>>>
>>> [1]
>> https://lore.kernel.org/bpf/20260216150445.68278-1-leon.hwang@linux.dev/
>
> It can be used when present, I will switch to a warning bit in the log
> level in the next version. But I don't think we need to rethink
> anything. If we want warnings for other objects they can use the log
> level's warning bit to supply those to user space as well. When you
> add support you already have to figure out how to merge those in
> bpf_attr and common attributes.
>
Make sense.
Thanks,
Leon
next prev parent reply other threads:[~2026-04-20 5:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-08 2:13 [PATCH bpf-next v2 0/6] Add support to emit verifier warnings Kumar Kartikeya Dwivedi
2026-04-08 2:13 ` [PATCH bpf-next v2 1/6] bpf: Add support for verifier warning messages Kumar Kartikeya Dwivedi
2026-04-08 8:46 ` sun jian
2026-04-08 2:13 ` [PATCH bpf-next v2 2/6] bpf: Extract bpf_get_linfo_file_line Kumar Kartikeya Dwivedi
2026-04-08 2:13 ` [PATCH bpf-next v2 3/6] bpf: Make find_linfo widely available Kumar Kartikeya Dwivedi
2026-04-08 15:46 ` Mykyta Yatsenko
2026-04-08 2:13 ` [PATCH bpf-next v2 4/6] bpf: Use KF_DEPRECATED to emit verifier warnings Kumar Kartikeya Dwivedi
2026-04-08 2:13 ` [PATCH bpf-next v2 5/6] bpf: Add __bpf_kfunc_replacement() annotation Kumar Kartikeya Dwivedi
2026-04-08 2:13 ` [PATCH bpf-next v2 6/6] libbpf: Flush verifier warning messages by default Kumar Kartikeya Dwivedi
2026-04-08 2:21 ` Kumar Kartikeya Dwivedi
2026-04-08 14:55 ` [PATCH bpf-next v2 0/6] Add support to emit verifier warnings Leon Hwang
2026-04-08 15:30 ` Leon Hwang
2026-04-18 11:06 ` Kumar Kartikeya Dwivedi
2026-04-20 5:45 ` Leon Hwang [this message]
2026-04-09 1:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e3e40b8b-9fff-4cb0-869e-fcaeb6b307ac@gmail.com \
--to=hffilwlqm@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=ihor.solodrai@linux.dev \
--cc=kernel-team@meta.com \
--cc=kkd@meta.com \
--cc=martin.lau@kernel.org \
--cc=memxor@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox