From: Xi Ruoyao <xry111@xry111.site>
To: Tiezhu Yang <yangtiezhu@loongson.cn>,
Huacai Chen <chenhuacai@kernel.org>
Cc: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>, bpf <bpf@vger.kernel.org>,
loongarch@lists.linux.dev
Subject: Re: [PATCH bpf-next v2 4/4] LoongArch: Enable BPF_JIT and TEST_BPF in default config
Date: Wed, 31 Aug 2022 17:02:18 +0800 [thread overview]
Message-ID: <e477e042aee090d6c3cf7ebeabed25df5b0fa07e.camel@xry111.site> (raw)
In-Reply-To: <75b27dacb8b4d779c6b2c0e46871baf404a32b6b.camel@xry111.site>
On Wed, 2022-08-31 at 12:12 +0800, Xi Ruoyao wrote:
> On Wed, 2022-08-31 at 09:23 +0800, Tiezhu Yang wrote:
> >
> >
> > On 08/30/2022 10:46 PM, Huacai Chen wrote:
> > > Hi, Tiezhu,
> > >
> > > On Tue, Aug 30, 2022 at 7:10 PM Tiezhu Yang
> > > <yangtiezhu@loongson.cn> wrote:
> > > >
> > > > For now, BPF JIT for LoongArch is supported, update
> > > > loongson3_defconfig to
> > > > enable BPF_JIT to allow the kernel to generate native code when
> > > > a program
> > > > is loaded into the kernel, and also enable TEST_BPF to test BPF
> > > > JIT.
> > > >
> > > > Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
> > > > ---
> > > > arch/loongarch/configs/loongson3_defconfig | 2 ++
> > > > 1 file changed, 2 insertions(+)
> > > >
> > > > diff --git a/arch/loongarch/configs/loongson3_defconfig
> > > > b/arch/loongarch/configs/loongson3_defconfig
> > > > index 3712552..93dc072 100644
> > > > --- a/arch/loongarch/configs/loongson3_defconfig
> > > > +++ b/arch/loongarch/configs/loongson3_defconfig
> > > > @@ -4,6 +4,7 @@ CONFIG_POSIX_MQUEUE=y
> > > > CONFIG_NO_HZ=y
> > > > CONFIG_HIGH_RES_TIMERS=y
> > > > CONFIG_BPF_SYSCALL=y
> > > > +CONFIG_BPF_JIT=y
> > > > CONFIG_PREEMPT=y
> > > > CONFIG_BSD_PROCESS_ACCT=y
> > > > CONFIG_BSD_PROCESS_ACCT_V3=y
> > > > @@ -801,3 +802,4 @@ CONFIG_MAGIC_SYSRQ=y
> > > > CONFIG_SCHEDSTATS=y
> > > > # CONFIG_DEBUG_PREEMPT is not set
> > > > # CONFIG_FTRACE is not set
> > > > +CONFIG_TEST_BPF=m
> > > I don't want the test module be built by default, but I don't
> > > insist
> > > if you have a strong requirement.
> > >
> >
> > Hi Huacai,
> >
> > It is useful to enable TEST_BPF in default config, otherwise we
> > need to use "make menuconfig" to select it manually if we want
> > to test bpf jit, and build it as a module by default has no side
> > effect, so I prefer to enable TEST_BPF in default config.
>
> IMO we shouldn't enable a test feature which is never used by 99% of
> users in the default.
P. S. this is not a strong option. CONFIG_TEST_BPF seems enabled by
default for S390, and I'm not sure if defconfig is designed for "kernel
developers" or "distro builders", or even "normal users".
--
Xi Ruoyao <xry111@xry111.site>
School of Aerospace Science and Technology, Xidian University
next prev parent reply other threads:[~2022-08-31 9:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-30 11:10 [PATCH bpf-next v2 0/4] Add BPF JIT support for LoongArch Tiezhu Yang
2022-08-30 11:10 ` [PATCH bpf-next v2 1/4] LoongArch: Move {signed,unsigned}_imm_check() to inst.h Tiezhu Yang
2022-08-30 11:10 ` [PATCH bpf-next v2 2/4] LoongArch: Add some instruction opcodes and formats Tiezhu Yang
2022-08-30 11:10 ` [PATCH bpf-next v2 3/4] LoongArch: Add BPF JIT support Tiezhu Yang
2022-08-30 11:10 ` [PATCH bpf-next v2 4/4] LoongArch: Enable BPF_JIT and TEST_BPF in default config Tiezhu Yang
2022-08-30 14:46 ` Huacai Chen
2022-08-31 1:23 ` Tiezhu Yang
2022-08-31 4:12 ` Xi Ruoyao
2022-08-31 9:02 ` Xi Ruoyao [this message]
2022-08-31 19:31 ` Daniel Borkmann
2022-09-01 1:30 ` Tiezhu Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e477e042aee090d6c3cf7ebeabed25df5b0fa07e.camel@xry111.site \
--to=xry111@xry111.site \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=chenhuacai@kernel.org \
--cc=daniel@iogearbox.net \
--cc=loongarch@lists.linux.dev \
--cc=yangtiezhu@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox