BPF List
 help / color / mirror / Atom feed
From: Yonghong Song <yhs@fb.com>
To: Delyan Kratunov <delyank@fb.com>,
	"daniel@iogearbox.net" <daniel@iogearbox.net>,
	"ast@kernel.org" <ast@kernel.org>,
	"andrii@kernel.org" <andrii@kernel.org>,
	"bpf@vger.kernel.org" <bpf@vger.kernel.org>
Subject: Re: [PATCH bpf-next v2 0/5] Subskeleton support for BPF libraries
Date: Fri, 11 Mar 2022 16:39:52 -0800	[thread overview]
Message-ID: <e5a052b0-eb53-196b-c911-f904e5fd40a5@fb.com> (raw)
In-Reply-To: <35a4dc621d45df496dab781b22d710e2dabaa1d3.camel@fb.com>



On 3/11/22 10:18 AM, Delyan Kratunov wrote:
> On Thu, 2022-03-10 at 21:10 -0800, Yonghong Song wrote:
>>
>> On 3/10/22 4:11 PM, Delyan Kratunov wrote:
> [..]
>>
>> When I tried to build the patch set with parallel mode (-j),
>>      make -C tools/testing/selftests/bpf -j
>> I hit the following errors:
>>
>> /bin/sh: line 1: 3484984 Bus error               (core dumped)
>> /home/yhs/work/bpf-next/tools/testing/selftests/bpf/tools/sbin/bpftool
>> gen skeleton
>> /home/yhs/work/bpf-next/tools/testing/selftests/bpf/test_ksyms_weak.linked3.o
>> name test_ksyms_weak >
>> /home/yhs/work/bpf-next/tools/testing/selftests/bpf/test_ksyms_weak.skel.h
>> make: *** [Makefile:496:
>> /home/yhs/work/bpf-next/tools/testing/selftests/bpf/test_ksyms_weak.skel.h]
>> Error 135
>> make: *** Deleting file
>> '/home/yhs/work/bpf-next/tools/testing/selftests/bpf/test_ksyms_weak.skel.h'
>> make: *** Waiting for unfinished jobs....
>> make: Leaving directory
>> '/home/yhs/work/bpf-next/tools/testing/selftests/bpf'
>>
>> Probably some make file related issues.
>> I didn't hit this issue before without this patch set.
> 
> Hm, that's interesting, can you reproduce it? I build everything with -j and
> have not seen any bpftool issues. I also use ASAN for bpftool and that's not
> complaining about anything either.

I can reproduce it in 50% of tries with command line:
   make -C tools/testing/selftests/bpf -j

> 
> SIGBUS suggests a memory mapped file was not there. I'll try and come up with
> ways that can happen, especially given that it's a `gen skeleton` invocation,
> which I haven't changed at all.
> 
> --Delyan

      reply	other threads:[~2022-03-12  0:40 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-11  0:11 [PATCH bpf-next v2 0/5] Subskeleton support for BPF libraries Delyan Kratunov
2022-03-11  0:11 ` [PATCH bpf-next v2 1/5] libbpf: add new strict flag for .text subprograms Delyan Kratunov
2022-03-11 22:30   ` Andrii Nakryiko
2022-03-11  0:11 ` [PATCH bpf-next v2 2/5] libbpf: init btf_{key,value}_type_id on internal map open Delyan Kratunov
2022-03-11 22:42   ` Andrii Nakryiko
2022-03-11  0:11 ` [PATCH bpf-next v2 3/5] libbpf: add subskeleton scaffolding Delyan Kratunov
2022-03-11 22:52   ` Andrii Nakryiko
2022-03-11 23:08     ` Andrii Nakryiko
2022-03-11 23:28       ` Delyan Kratunov
2022-03-11 23:41         ` Andrii Nakryiko
2022-03-11  0:11 ` [PATCH bpf-next v2 4/5] bpftool: add support for subskeletons Delyan Kratunov
2022-03-11 23:27   ` Andrii Nakryiko
2022-03-14 23:18     ` Delyan Kratunov
2022-03-15 17:28       ` Delyan Kratunov
2022-03-15 18:07         ` Andrii Nakryiko
2022-03-15 18:07       ` Andrii Nakryiko
2022-03-11  0:12 ` [PATCH bpf-next v2 5/5] selftests/bpf: test subskeleton functionality Delyan Kratunov
2022-03-11 23:40   ` Andrii Nakryiko
2022-03-14 23:50     ` Delyan Kratunov
2022-03-15 18:31       ` Andrii Nakryiko
2022-03-11  5:10 ` [PATCH bpf-next v2 0/5] Subskeleton support for BPF libraries Yonghong Song
2022-03-11 18:18   ` Delyan Kratunov
2022-03-12  0:39     ` Yonghong Song [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e5a052b0-eb53-196b-c911-f904e5fd40a5@fb.com \
    --to=yhs@fb.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=delyank@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox