From: Alexander Lobakin <aleksander.lobakin@intel.com>
To: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Martin KaFai Lau <martin.lau@linux.dev>
Cc: "Maciej Fijalkowski" <maciej.fijalkowski@intel.com>,
"Larysa Zaremba" <larysa.zaremba@intel.com>,
"Toke Høiland-Jørgensen" <toke@redhat.com>,
"Song Liu" <song@kernel.org>,
"Jesper Dangaard Brouer" <hawk@kernel.org>,
"Menglong Dong" <imagedong@tencent.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Eric Dumazet" <edumazet@google.com>,
bpf@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH bpf-next v2 0/3] xdp: recycle Page Pool backed skbs built from XDP frames
Date: Thu, 9 Mar 2023 17:25:40 +0100 [thread overview]
Message-ID: <e5be0165-c398-c84b-4f16-18e5b302290d@intel.com> (raw)
In-Reply-To: <20230303133232.2546004-1-aleksander.lobakin@intel.com>
From: Alexander Lobakin <aleksander.lobakin@intel.com>
Date: Fri, 3 Mar 2023 14:32:29 +0100
> Yeah, I still remember that "Who needs cpumap nowadays" (c), but anyway.
>
> __xdp_build_skb_from_frame() missed the moment when the networking stack
> became able to recycle skb pages backed by a page_pool. This was making
> e.g. cpumap redirect even less effective than simple %XDP_PASS. veth was
> also affected in some scenarios.
> A lot of drivers use skb_mark_for_recycle() already, it's been almost
> two years and seems like there are no issues in using it in the generic
> code too. {__,}xdp_release_frame() can be then removed as it losts its
> last user.
> Page Pool becomes then zero-alloc (or almost) in the abovementioned
> cases, too. Other memory type models (who needs them at this point)
> have no changes.
Ping?
The discussion in the v1 thread is unrelated to the patch subject :D
[...]
Thanks,
Olek
next prev parent reply other threads:[~2023-03-09 16:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-03 13:32 [PATCH bpf-next v2 0/3] xdp: recycle Page Pool backed skbs built from XDP frames Alexander Lobakin
2023-03-03 13:32 ` [PATCH bpf-next v2 1/3] net: page_pool, skbuff: make skb_mark_for_recycle() always available Alexander Lobakin
2023-03-03 13:32 ` [PATCH bpf-next v2 2/3] xdp: recycle Page Pool backed skbs built from XDP frames Alexander Lobakin
2023-03-03 13:32 ` [PATCH bpf-next v2 3/3] xdp: remove unused {__,}xdp_release_frame() Alexander Lobakin
2023-03-09 16:25 ` Alexander Lobakin [this message]
2023-03-09 16:43 ` [PATCH bpf-next v2 0/3] xdp: recycle Page Pool backed skbs built from XDP frames Jesper Dangaard Brouer
2023-03-10 15:52 ` Alexander Lobakin
2023-03-10 18:33 ` Alexei Starovoitov
2023-03-10 20:10 ` Alexander Lobakin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5be0165-c398-c84b-4f16-18e5b302290d@intel.com \
--to=aleksander.lobakin@intel.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=imagedong@tencent.com \
--cc=kuba@kernel.org \
--cc=larysa.zaremba@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=martin.lau@linux.dev \
--cc=netdev@vger.kernel.org \
--cc=song@kernel.org \
--cc=toke@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox