BPF List
 help / color / mirror / Atom feed
From: Eduard Zingerman <eddyz87@gmail.com>
To: Tony Ambardar <tony.ambardar@gmail.com>
Cc: andrii@kernel.org, daniel@iogearbox.net, martin.lau@linux.dev,
	 kernel-team@fb.com, yonghong.song@linux.dev,
	bpf@vger.kernel.org, Alexei Starovoitov <ast@kernel.org>
Subject: Re: [PATCH bpf] selftests/bpf: fix backtrace printing for selftests crashes
Date: Thu, 03 Oct 2024 14:07:23 -0700	[thread overview]
Message-ID: <e5ef86e9bed0f3e1f4a7ad81301e0fe0a0063bb2.camel@gmail.com> (raw)
In-Reply-To: <20241003210307.3847907-1-eddyz87@gmail.com>

On Thu, 2024-10-03 at 14:03 -0700, Eduard Zingerman wrote:

[...]

> Resolve this by hiding stub definitions behind __GLIBC__ macro check
> instead of using "weak" attribute.
> 
> Fixes: c9a83e76b5a9 ("selftests/bpf: Fix compile if backtrace support missing in libc")

Hi Tony,

could you please double-check if your musl setup behaves as expected
after these changes?

Thanks,
Eduard


  reply	other threads:[~2024-10-03 21:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-03 21:03 [PATCH bpf] selftests/bpf: fix backtrace printing for selftests crashes Eduard Zingerman
2024-10-03 21:07 ` Eduard Zingerman [this message]
2024-10-06  8:12   ` Tony Ambardar
2024-10-08  3:39     ` Andrii Nakryiko
2024-10-04 17:21 ` Daniel Xu
2024-10-08  3:40 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e5ef86e9bed0f3e1f4a7ad81301e0fe0a0063bb2.camel@gmail.com \
    --to=eddyz87@gmail.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=kernel-team@fb.com \
    --cc=martin.lau@linux.dev \
    --cc=tony.ambardar@gmail.com \
    --cc=yonghong.song@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox