BPF List
 help / color / mirror / Atom feed
From: Kui-Feng Lee <kuifeng@fb.com>
To: "daniel@iogearbox.net" <daniel@iogearbox.net>,
	Kernel Team <Kernel-team@fb.com>,
	"ast@kernel.org" <ast@kernel.org>,
	"andrii@kernel.org" <andrii@kernel.org>,
	"bpf@vger.kernel.org" <bpf@vger.kernel.org>
Subject: Re: [PATCH bpf-next v3 0/5] Attach a cookie to a tracing program.
Date: Mon, 11 Apr 2022 17:36:10 +0000	[thread overview]
Message-ID: <e957179a04f4aa9c2a68e6c5cbc3b7f276e49c8e.camel@fb.com> (raw)
In-Reply-To: <283a6823-0f19-4f91-a111-752590776b7c@iogearbox.net>

On Fri, 2022-04-08 at 23:33 +0200, Daniel Borkmann wrote:
> On 4/7/22 9:25 PM, Kui-Feng Lee wrote:
> > Allow users to attach a 64-bits cookie to a bpf_link of fentry,
> > fexit,
> > or fmod_ret.
> > 
> > This patchset includes several major changes.
> > 
> >   - Define struct bpf_tramp_links to replace bpf_tramp_prog.
> >     struct bpf_tramp_links collects bpf_links of a trampoline
> > 
> >   - Generate a trampoline to call bpf_progs of given bpf_links.
> > 
> >   - Trampolines always set/reset bpf_run_ctx before/after
> >     calling/leaving a tracing program.
> > 
> >   - Attach a cookie to a bpf_link of fentry/fexit/fmod_ret.  The
> > value
> >     will be available when running the associated bpf_prog.
> > 
> > The major differences from v2:
> > 
> >   - Move the allocations of run_ctx (struct bpf_tramp_run_ctx) out
> > of
> >     invoke_bpf_prog().
> > 
> >   - Move hlist_node out of bpf_link and introduce struct
> > bpf_tramp_link
> >     to own hlist_node.
> > 
> >   - Store cookies at struct bpf_tracing_link.
> > 
> >   - Use SIB byte to reduce the number of instructions to set cookie
> >     values. (Use RSP directly)
> > 
> > v1:
> > https://lore.kernel.org/all/20220126214809.3868787-1-kuifeng@fb.com/
> > v2:
> > https://lore.kernel.org/bpf/20220316004231.1103318-1-kuifeng@fb.com/
> 
> Kui-Feng, would be great if you have a chance to rebase, so that the
> set can
> also go through BPF CI.
> 
> Thanks a lot,
> Daniel
Yes, just sent new patches out.


      reply	other threads:[~2022-04-11 17:36 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-07 19:25 [PATCH bpf-next v3 0/5] Attach a cookie to a tracing program Kui-Feng Lee
2022-04-07 19:25 ` [PATCH bpf-next v3 1/5] bpf, x86: Generate trampolines from bpf_tramp_links Kui-Feng Lee
2022-04-07 19:25 ` [PATCH bpf-next v3 2/5] bpf, x86: Create bpf_tramp_run_ctx on the caller thread's stack Kui-Feng Lee
2022-04-09  0:01   ` Alexei Starovoitov
2022-04-07 19:25 ` [PATCH bpf-next v3 3/5] bpf, x86: Attach a cookie to fentry/fexit/fmod_ret Kui-Feng Lee
2022-04-07 19:25 ` [PATCH bpf-next v3 4/5] lib/bpf: Assign cookies to links in libbpf Kui-Feng Lee
2022-04-07 19:25 ` [PATCH bpf-next v3 5/5] selftest/bpf: The test cses of BPF cookie for fentry/fexit/fmod_ret Kui-Feng Lee
2022-04-08 21:33 ` [PATCH bpf-next v3 0/5] Attach a cookie to a tracing program Daniel Borkmann
2022-04-11 17:36   ` Kui-Feng Lee [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e957179a04f4aa9c2a68e6c5cbc3b7f276e49c8e.camel@fb.com \
    --to=kuifeng@fb.com \
    --cc=Kernel-team@fb.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox