From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFB40C433FE for ; Tue, 12 Apr 2022 02:53:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231991AbiDLCz5 (ORCPT ); Mon, 11 Apr 2022 22:55:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46568 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245484AbiDLCz4 (ORCPT ); Mon, 11 Apr 2022 22:55:56 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 1D1BF2494B for ; Mon, 11 Apr 2022 19:53:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1649732019; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=I6Gk+PoKhwefvMstrrWueNlGg+EH3BPUAhekn6Cxf1E=; b=MqbtELB8txoGce7zNydutrAgVuoIcgASPLdgQeyAMIh6FINqlxJZ9HcXPNQBUZVmMcBZKT wh9XVdDbhuJu9Grd9CQ3W/wfwB+m5n0hO856iySDvjRNQJaRnS+vI3xA5waROBXG9p7k8w 4iTTIzL6gH8xZw9mFK5P8p8N99vlCHY= Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-594-fpDFiQFAOV2fWWoQBh-J8w-1; Mon, 11 Apr 2022 22:53:37 -0400 X-MC-Unique: fpDFiQFAOV2fWWoQBh-J8w-1 Received: by mail-pf1-f200.google.com with SMTP id h131-20020a628389000000b005056723a9dcso8413202pfe.8 for ; Mon, 11 Apr 2022 19:53:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=I6Gk+PoKhwefvMstrrWueNlGg+EH3BPUAhekn6Cxf1E=; b=NjnUpMefH3cOJx3WLOv/lmhQUFggq5GxV7HC+C9RAr1QvR2bLYrzVgXd3oRPLG3vQe K1IMIGKtRmndw3dEXidlgEJkPl5gfmcAkd0zGu/67crnJVDektyO4+PGOO6ci5iYaM8v GpIFF6qHeGMTRmF5MlE1pGCJDt5JSSssM4IMJno8hEA/+EEkohJWXd8ygCFjxA8s0ixq M7OHpbam6gLl0zsa8MBQ7bvjp1cF9fWOaZxgwypOWMP+FWPFjHnKXLdu9c8JG/jemUR+ WzPKyXduQON+YhbpI06eWVgqSMF7RNuMhzaptmdJ3zBAzk5r5ej8mSgxqriajbXQR/eF EjUQ== X-Gm-Message-State: AOAM533+EDpV8ll+E0dUiWXaBEFkpDSBuYFXgzQWUpEDbflxjNIxGw0j M13yJKNWkT4xE4QZV5yGrPx1hqSot7PXBhc8M/EwIOEGOO3HuWB7vQB5IDnLhHM16acd8prA+A+ aXInQDtScrZWj X-Received: by 2002:a63:6286:0:b0:39d:94b2:fbc0 with SMTP id w128-20020a636286000000b0039d94b2fbc0mr996914pgb.439.1649732016631; Mon, 11 Apr 2022 19:53:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzj9451Dz8Id3VkVV78O8W6jxJ5RgF2YxbCU8kZmbBeEtMyuWRJome1nhMw4/Xpk0k7lbQNPw== X-Received: by 2002:a63:6286:0:b0:39d:94b2:fbc0 with SMTP id w128-20020a636286000000b0039d94b2fbc0mr996881pgb.439.1649732016356; Mon, 11 Apr 2022 19:53:36 -0700 (PDT) Received: from [10.72.14.5] ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id np8-20020a17090b4c4800b001c70aeab380sm812652pjb.41.2022.04.11.19.53.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 Apr 2022 19:53:35 -0700 (PDT) Message-ID: Date: Tue, 12 Apr 2022 10:53:22 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v9 04/32] virtio_ring: remove the arg vq of vring_alloc_desc_extra() Content-Language: en-US To: Xuan Zhuo , virtualization@lists.linux-foundation.org Cc: Jeff Dike , Richard Weinberger , Anton Ivanov , "Michael S. Tsirkin" , "David S. Miller" , Jakub Kicinski , Hans de Goede , Mark Gross , Vadim Pasternak , Bjorn Andersson , Mathieu Poirier , Cornelia Huck , Halil Pasic , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Alexander Gordeev , Sven Schnelle , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Johannes Berg , Vincent Whitchurch , linux-um@lists.infradead.org, netdev@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, kvm@vger.kernel.org, bpf@vger.kernel.org References: <20220406034346.74409-1-xuanzhuo@linux.alibaba.com> <20220406034346.74409-5-xuanzhuo@linux.alibaba.com> From: Jason Wang In-Reply-To: <20220406034346.74409-5-xuanzhuo@linux.alibaba.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org 在 2022/4/6 上午11:43, Xuan Zhuo 写道: > The parameter vq of vring_alloc_desc_extra() is useless. This patch > removes this parameter. > > Subsequent patches will call this function to avoid passing useless > arguments. > > Signed-off-by: Xuan Zhuo Acked-by: Jason Wang > --- > drivers/virtio/virtio_ring.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c > index f1807f6b06a5..cb6010750a94 100644 > --- a/drivers/virtio/virtio_ring.c > +++ b/drivers/virtio/virtio_ring.c > @@ -1636,8 +1636,7 @@ static void *virtqueue_detach_unused_buf_packed(struct virtqueue *_vq) > return NULL; > } > > -static struct vring_desc_extra *vring_alloc_desc_extra(struct vring_virtqueue *vq, > - unsigned int num) > +static struct vring_desc_extra *vring_alloc_desc_extra(unsigned int num) > { > struct vring_desc_extra *desc_extra; > unsigned int i; > @@ -1755,7 +1754,7 @@ static struct virtqueue *vring_create_virtqueue_packed( > /* Put everything in free lists. */ > vq->free_head = 0; > > - vq->packed.desc_extra = vring_alloc_desc_extra(vq, num); > + vq->packed.desc_extra = vring_alloc_desc_extra(num); > if (!vq->packed.desc_extra) > goto err_desc_extra; > > @@ -2233,7 +2232,7 @@ struct virtqueue *__vring_new_virtqueue(unsigned int index, > if (!vq->split.desc_state) > goto err_state; > > - vq->split.desc_extra = vring_alloc_desc_extra(vq, vring.num); > + vq->split.desc_extra = vring_alloc_desc_extra(vring.num); > if (!vq->split.desc_extra) > goto err_extra; >