From: Daniel Borkmann <daniel@iogearbox.net>
To: Eric Dumazet <edumazet@google.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com,
syzbot <syzkaller@googlegroups.com>,
"Björn Töpel" <bjorn@kernel.org>,
"Magnus Karlsson" <magnus.karlsson@intel.com>,
"Maciej Fijalkowski" <maciej.fijalkowski@intel.com>,
"Jonathan Lemon" <jonathan.lemon@gmail.com>,
bpf@vger.kernel.org
Subject: Re: [PATCH net] xsk: validate user input for XDP_{UMEM|COMPLETION}_FILL_RING
Date: Thu, 4 Apr 2024 22:56:21 +0200 [thread overview]
Message-ID: <ea789237-3f4d-267f-4aeb-85ca4d9fc0c4@iogearbox.net> (raw)
In-Reply-To: <20240404202738.3634547-1-edumazet@google.com>
On 4/4/24 10:27 PM, Eric Dumazet wrote:
> syzbot reported an illegal copy in xsk_setsockopt() [1]
>
> Make sure to validate setsockopt() @optlen parameter.
>
[...]
>
> Fixes: 423f38329d26 ("xsk: add umem fill queue support and mmap")
> Reported-by: syzbot <syzkaller@googlegroups.com>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Cc: "Björn Töpel" <bjorn@kernel.org>
> Cc: Magnus Karlsson <magnus.karlsson@intel.com>
> Cc: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
> Cc: Jonathan Lemon <jonathan.lemon@gmail.com>
> Cc: bpf@vger.kernel.org
Given bpf tree PR went out, Jakub, feel free to take directly :
Acked-by: Daniel Borkmann <daniel@iogearbox.net>
Thanks Eric !
next prev parent reply other threads:[~2024-04-04 21:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-04 20:27 [PATCH net] xsk: validate user input for XDP_{UMEM|COMPLETION}_FILL_RING Eric Dumazet
2024-04-04 20:56 ` Daniel Borkmann [this message]
2024-04-06 6:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea789237-3f4d-267f-4aeb-85ca4d9fc0c4@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=bjorn@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=jonathan.lemon@gmail.com \
--cc=kuba@kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=syzkaller@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox