From: "Abhishek Chauhan (ABC)" <quic_abchauha@quicinc.com>
To: Martin KaFai Lau <martin.lau@linux.dev>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Andrew Halaney <ahalaney@redhat.com>,
"Willem de Bruijn" <willemdebruijn.kernel@gmail.com>,
Martin KaFai Lau <martin.lau@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>, bpf <bpf@vger.kernel.org>,
<kernel@quicinc.com>,
<syzbot+d7b227731ec589e7f4f0@syzkaller.appspotmail.com>,
<syzbot+30a35a2e9c5067cc43fa@syzkaller.appspotmail.com>
Subject: Re: [PATCH net] net: validate SO_TXTIME clockid coming from userspace
Date: Tue, 28 May 2024 20:32:05 -0700 [thread overview]
Message-ID: <ecac6276-c2e1-43b8-88ad-6ae91cff18cf@quicinc.com> (raw)
In-Reply-To: <2c363f12-dd52-4163-bbcd-9a017cff6dd4@linux.dev>
On 5/28/2024 6:15 PM, Martin KaFai Lau wrote:
> On 5/28/24 3:49 PM, Abhishek Chauhan wrote:
>> Currently there are no strict checks while setting SO_TXTIME
>> from userspace. With the recent development in skb->tstamp_type
>> clockid with unsupported clocks results in warn_on_once, which causes
>> unnecessary aborts in some systems which enables panic on warns.
>>
>> Add validation in setsockopt to support only CLOCK_REALTIME,
>> CLOCK_MONOTONIC and CLOCK_TAI to be set from userspace.
>>
>> Link: https://lore.kernel.org/netdev/bc037db4-58bb-4861-ac31-a361a93841d3@linux.dev/
>> Link: https://lore.kernel.org/lkml/20240509211834.3235191-1-quic_abchauha@quicinc.com/
>> Fixes: 1693c5db6ab8 ("net: Add additional bit to support clockid_t timestamp type")
>
> Patch lgtm. This should target for net-next instead of net. The Fixes patch is in net-next only.
>
Thanks Martin. Let me raise a patch on net-next and add your acked-by to it as well.
> Acked-by: Martin KaFai Lau <martin.lau@kernel.org>
>
next prev parent reply other threads:[~2024-05-29 3:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-28 22:49 [PATCH net] net: validate SO_TXTIME clockid coming from userspace Abhishek Chauhan
2024-05-29 1:15 ` Martin KaFai Lau
2024-05-29 3:32 ` Abhishek Chauhan (ABC) [this message]
2024-05-29 13:58 ` Willem de Bruijn
2024-05-29 15:49 ` Abhishek Chauhan (ABC)
2024-05-29 16:00 ` Willem de Bruijn
2024-05-29 16:04 ` Abhishek Chauhan (ABC)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ecac6276-c2e1-43b8-88ad-6ae91cff18cf@quicinc.com \
--to=quic_abchauha@quicinc.com \
--cc=ahalaney@redhat.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kernel@quicinc.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.lau@kernel.org \
--cc=martin.lau@linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=syzbot+30a35a2e9c5067cc43fa@syzkaller.appspotmail.com \
--cc=syzbot+d7b227731ec589e7f4f0@syzkaller.appspotmail.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox