From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3DF7C43217 for ; Mon, 21 Nov 2022 10:12:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229827AbiKUKMO (ORCPT ); Mon, 21 Nov 2022 05:12:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48812 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231358AbiKUKMI (ORCPT ); Mon, 21 Nov 2022 05:12:08 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5CF3F13FB2 for ; Mon, 21 Nov 2022 02:11:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669025471; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NwLjb0E2762mkBoRuKP5ZO/x2E2Yg04BUzrNFBoai9w=; b=ZLpKgzlFGZV/H7T1QT7oJc+wTz7c5+tfsKiBhyuxI6tV7xMMxyrHIkzMm6A0yxPu1LxuL1 2M5Dqx3dUzdQJwQQBWhB5KALf/7h4nhbQIYNr9Zj1+wuC+P6qtJUE7TPxKMXcuM2W7HAvs 5/bBI5qQGdHMlmNWKfMEIL75OkaXAFg= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-561-shqAWD8sMzSLCmHjQLRAqQ-1; Mon, 21 Nov 2022 05:11:10 -0500 X-MC-Unique: shqAWD8sMzSLCmHjQLRAqQ-1 Received: by mail-qk1-f197.google.com with SMTP id v7-20020a05620a0f0700b006faffce43b2so14965047qkl.9 for ; Mon, 21 Nov 2022 02:11:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=NwLjb0E2762mkBoRuKP5ZO/x2E2Yg04BUzrNFBoai9w=; b=wHeGO2ss1NFDlTuN9mRV0koQIjz0bdvOPoZIgFR/o5jUx1rFblWjfAlYn7taxox4Ae etK582vqlQtW3FbAhZX1/R3td8ksHJCyHORTR9zVjrgHpdmEvH1XA6iwm2ElqEhCwy8w 39FLmuR3xDwU7nGOk4zsur5h/horm4MLR6HhCOxjgiWpcOJ8IaCqF6WfN3JFRz/kGZoN fm4+V7HZVqNtQxji7ByZFfdPx6oL6149nfHOy1eY3mBurqDWPmD6KfLtdOsD/Sc+FuHp VFOYXvgyx0lzmqLWaYQUgza4BQyu496bTm50pyqVZtlq3REYkwkanFV3G0eTqouZbNV+ 5spw== X-Gm-Message-State: ANoB5pmtZAU21JyAMmuCyFiZBIDHntU3Tj1SvIv1f36X+7z0LGzYr0Wi 4MH+78IgXVimy7zOPQNUIloMYYY1Lglh/p80AHfAuHVfs4b/vYEh4lRDtPo/W0lOF/byapoaWmm QNrF3Zw3QuIRb X-Received: by 2002:a37:5885:0:b0:6fa:1ef8:49dc with SMTP id m127-20020a375885000000b006fa1ef849dcmr15618252qkb.314.1669025469503; Mon, 21 Nov 2022 02:11:09 -0800 (PST) X-Google-Smtp-Source: AA0mqf71eq5OjrF2ILYGHiO1RNCvRVc/hZiNHJD5N51HaDY3vkNB/0Mm+r5QjLEFpRdkiy8bI24xmA== X-Received: by 2002:a37:5885:0:b0:6fa:1ef8:49dc with SMTP id m127-20020a375885000000b006fa1ef849dcmr15618235qkb.314.1669025469169; Mon, 21 Nov 2022 02:11:09 -0800 (PST) Received: from gerbillo.redhat.com (146-241-120-203.dyn.eolo.it. [146.241.120.203]) by smtp.gmail.com with ESMTPSA id t7-20020a37ea07000000b006fa2cc1b0fbsm7906162qkj.11.2022.11.21.02.11.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Nov 2022 02:11:08 -0800 (PST) Message-ID: Subject: Re: [PATCH net-next 0/2] veth: a couple of fixes From: Paolo Abeni To: Heng Qi , Xuan Zhuo Cc: bpf@vger.kernel.org, netdev@vger.kernel.org, Jakub Kicinski , John Fastabend Date: Mon, 21 Nov 2022 11:11:05 +0100 In-Reply-To: References: <1669001595.7554848-1-xuanzhuo@linux.alibaba.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.4 (3.42.4-2.fc35) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Mon, 2022-11-21 at 11:55 +0800, Heng Qi wrote: > 在 2022/11/21 上午11:33, Xuan Zhuo 写道: > > On Fri, 18 Nov 2022 09:41:05 +0100, Paolo Abeni wrote: > > > On Fri, 2022-11-18 at 00:33 +0100, Paolo Abeni wrote: > > > > Recent changes in the veth driver caused a few regressions > > > > this series addresses a couple of them, causing oops. > > > > > > > > Paolo Abeni (2): > > > > veth: fix uninitialized napi disable > > > > veth: fix double napi enable > > > > > > > > drivers/net/veth.c | 6 ++++-- > > > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > @Xuan Zhuo: another option would be reverting 2e0de6366ac1 ("veth: > > > Avoid drop packets when xdp_redirect performs") and its follow-up > > > 5e5dc33d5dac ("bpf: veth driver panics when xdp prog attached before > > > veth_open"). > > > option would be possibly safer, because I feel there are other > > > issues with 2e0de6366ac1, and would offer the opportunity to refactor > > > its logic a bit: the napi enable/disable condition is quite complex and > > > not used consistently mixing and alternating the gro/xdp/peer xdp check > > > with the napi ptr dereference. > > > > > > Ideally it would be better to have an helper alike > > > napi_should_be_enabled(), use it everywhere, and pair the new code with > > > some selftests, extending the existing ones. > > > > > > WDYT? > > I take your point. > > I'll rewrite a patch as soon as possible and resubmit it. Could you please first send the revert? Thanks! Paolo