From: Kui-Feng Lee <sinquersw@gmail.com>
To: Martin KaFai Lau <martin.lau@linux.dev>, Kui-Feng Lee <kuifeng@meta.com>
Cc: bpf@vger.kernel.org, ast@kernel.org, song@kernel.org,
kernel-team@meta.com, andrii@kernel.org, sdf@google.com
Subject: Re: [PATCH bpf-next v9 8/8] selftests/bpf: Test switching TCP Congestion Control algorithms.
Date: Tue, 21 Mar 2023 16:05:10 -0700 [thread overview]
Message-ID: <ef602c94-2978-e4e3-02e8-1ce9bbc2e1c9@gmail.com> (raw)
In-Reply-To: <b7738b11-0260-eb60-7788-791a070c30a0@linux.dev>
On 3/21/23 14:05, Martin KaFai Lau wrote:
> On 3/20/23 12:56 PM, Kui-Feng Lee wrote:
>> Create a pair of sockets that utilize the congestion control algorithm
>> under a particular name. Then switch up this congestion control
>> algorithm to another implementation and check whether newly created
>> connections using the same cc name now run the new implementation.
>>
>> Also, try to update a link with a struct_ops that is without
>> BPF_F_LINK or with a wrong or different name. These cases should fail
>> due to the violation of assumptions. To update a bpf_link of a
>> struct_ops, it must be replaced with another struct_ops that is
>> identical in type and name and has the BPF_F_LINK flag.
>>
>> The other test case is to create links from the same struct_ops more
>> than once. It makes sure a struct_ops can be used repeatly.
>
> Test for BPF_F_REPLACE is needed.
>
Sure!
next prev parent reply other threads:[~2023-03-21 23:05 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-20 19:56 [PATCH bpf-next v9 0/8] Transit between BPF TCP congestion controls Kui-Feng Lee
2023-03-20 19:56 ` [PATCH bpf-next v9 1/8] bpf: Retire the struct_ops map kvalue->refcnt Kui-Feng Lee
2023-03-20 19:56 ` [PATCH bpf-next v9 2/8] net: Update an existing TCP congestion control algorithm Kui-Feng Lee
2023-03-20 19:56 ` [PATCH bpf-next v9 3/8] bpf: Create links for BPF struct_ops maps Kui-Feng Lee
2023-03-20 19:56 ` [PATCH bpf-next v9 4/8] libbpf: Create a bpf_link in bpf_map__attach_struct_ops() Kui-Feng Lee
2023-03-21 17:49 ` Martin KaFai Lau
2023-03-21 23:03 ` Kui-Feng Lee
2023-03-20 19:56 ` [PATCH bpf-next v9 5/8] bpf: Update the struct_ops of a bpf_link Kui-Feng Lee
2023-03-21 18:18 ` Martin KaFai Lau
2023-03-21 23:04 ` Kui-Feng Lee
2023-03-20 19:56 ` [PATCH bpf-next v9 6/8] libbpf: Update a bpf_link with another struct_ops Kui-Feng Lee
2023-03-21 21:04 ` Martin KaFai Lau
2023-03-21 23:04 ` Kui-Feng Lee
2023-03-20 19:56 ` [PATCH bpf-next v9 7/8] libbpf: Use .struct_ops.link section to indicate a struct_ops with a link Kui-Feng Lee
2023-03-20 19:56 ` [PATCH bpf-next v9 8/8] selftests/bpf: Test switching TCP Congestion Control algorithms Kui-Feng Lee
2023-03-21 21:05 ` Martin KaFai Lau
2023-03-21 23:05 ` Kui-Feng Lee [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-03-20 19:24 [PATCH bpf-next v9 0/8] Transit between BPF TCP congestion controls Kui-Feng Lee
2023-03-20 19:24 ` [PATCH bpf-next v9 8/8] selftests/bpf: Test switching TCP Congestion Control algorithms Kui-Feng Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef602c94-2978-e4e3-02e8-1ce9bbc2e1c9@gmail.com \
--to=sinquersw@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=kernel-team@meta.com \
--cc=kuifeng@meta.com \
--cc=martin.lau@linux.dev \
--cc=sdf@google.com \
--cc=song@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox