* [PATCH -next] bpf: change bpf_alu_sign_string and bpf_movsx_string to static
@ 2023-08-03 2:31 Yang Yingliang
2023-08-03 5:27 ` Yonghong Song
2023-08-04 22:40 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Yang Yingliang @ 2023-08-03 2:31 UTC (permalink / raw)
To: bpf; +Cc: yonghong.song, eddyz87, quentin, ast, yangyingliang
The bpf_alu_sign_string and bpf_movsx_string introduced in commit
f835bb622299 ("bpf: Add kernel/bpftool asm support for new instructions")
are only used in disasm.c now, change them to static.
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
kernel/bpf/disasm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/bpf/disasm.c b/kernel/bpf/disasm.c
index d7bff608f299..d99ab716d78e 100644
--- a/kernel/bpf/disasm.c
+++ b/kernel/bpf/disasm.c
@@ -87,12 +87,12 @@ const char *const bpf_alu_string[16] = {
[BPF_END >> 4] = "endian",
};
-const char *const bpf_alu_sign_string[16] = {
+static const char *const bpf_alu_sign_string[16] = {
[BPF_DIV >> 4] = "s/=",
[BPF_MOD >> 4] = "s%=",
};
-const char *const bpf_movsx_string[4] = {
+static const char *const bpf_movsx_string[4] = {
[0] = "(s8)",
[1] = "(s16)",
[3] = "(s32)",
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH -next] bpf: change bpf_alu_sign_string and bpf_movsx_string to static
2023-08-03 2:31 [PATCH -next] bpf: change bpf_alu_sign_string and bpf_movsx_string to static Yang Yingliang
@ 2023-08-03 5:27 ` Yonghong Song
2023-08-04 22:40 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Yonghong Song @ 2023-08-03 5:27 UTC (permalink / raw)
To: Yang Yingliang, bpf; +Cc: eddyz87, quentin, ast
On 8/2/23 7:31 PM, Yang Yingliang wrote:
> The bpf_alu_sign_string and bpf_movsx_string introduced in commit
> f835bb622299 ("bpf: Add kernel/bpftool asm support for new instructions")
> are only used in disasm.c now, change them to static.
>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Thanks for the fix!
Acked-by: Yonghong Song <yonghong.song@linux.dev>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH -next] bpf: change bpf_alu_sign_string and bpf_movsx_string to static
2023-08-03 2:31 [PATCH -next] bpf: change bpf_alu_sign_string and bpf_movsx_string to static Yang Yingliang
2023-08-03 5:27 ` Yonghong Song
@ 2023-08-04 22:40 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-08-04 22:40 UTC (permalink / raw)
To: Yang Yingliang; +Cc: bpf, yonghong.song, eddyz87, quentin, ast
Hello:
This patch was applied to bpf/bpf-next.git (master)
by Martin KaFai Lau <martin.lau@kernel.org>:
On Thu, 3 Aug 2023 10:31:28 +0800 you wrote:
> The bpf_alu_sign_string and bpf_movsx_string introduced in commit
> f835bb622299 ("bpf: Add kernel/bpftool asm support for new instructions")
> are only used in disasm.c now, change them to static.
>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
> kernel/bpf/disasm.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Here is the summary with links:
- [-next] bpf: change bpf_alu_sign_string and bpf_movsx_string to static
https://git.kernel.org/bpf/bpf-next/c/09d15054c467
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-08-04 22:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-03 2:31 [PATCH -next] bpf: change bpf_alu_sign_string and bpf_movsx_string to static Yang Yingliang
2023-08-03 5:27 ` Yonghong Song
2023-08-04 22:40 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox