From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm2-f12.google.com (mail-wm2-f12.google.com [74.125.225.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BD23E4A7C95 for ; Wed, 16 Sep 2026 17:08:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.225.140 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789578532; cv=none; b=u/E8gDCm4+rc0jIq5MqL9m7/w+qwaPtW+eavbkUvjWXlJkHaNfGJl460DxyEK10UBnxMJ6DUI7GqyqtjdcqVC0KmehontxWi9/aBKCd2XLGv387R9YMY75tbvui9kyJgl028PhpgZ8Ok9zpUE84iIwVtKOMuMM+Dl/B17joINEc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789578532; c=relaxed/simple; bh=KQwTtWF9e7NnliGZSfK0AfwbAMFtivtvmguqsIAkOVQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=dliGgaAkrBwc8QMsDn+08fjeejnay/F4Pt7gwpvWKpBhzbeTAbQ5ta5Iu882vbwEenGly4B5mmrYbZhfOwYwj5IqHz9QfetpNYcYVP+pEbYAazX3PaUVhSRiKhc1TrVrt8j5et8Pl8TcyAc95Bv0k/T3Ed8JoSyz6pl/9eaUDI0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=atdrWoYt; arc=none smtp.client-ip=74.125.225.140 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="atdrWoYt" Received: by mail-wm2-f12.google.com with SMTP id 5b1f17b1804b1-49cc9f581c4so4794325e9.0 for ; Wed, 16 Sep 2026 10:08:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789578522; x=1790183322; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=N28J0VzbFodwXxNV+R6CAv+u3dHEZ4luEdBN+JrJawg=; b=atdrWoYtE3CLXaCxzbLIfhuMSk0dQw2pDiXavixMP2Gm5xuY7WUgCLxa04FuF2Xe0y vIWPEoq5J9RGHFImdtnOeprXBuhDu1M2b2pJdshoeMxskmD/iz9iWcvxORpCulFon/B0 SykjdLm5EUvKQtKdAI50oEHdUSIFwgyfVVWhf3MtgOz3yMwi/TKa3MrGofN9gxjSlN3J BT3yrmEbjqAgvPamFgPTQwnOHq6C9RtMopOhPnSvF7hBjTIJN6shvjpqzUDIaehdHzE4 2GWeWLazP77hflvX94vhgj48MLfVpUtYPLIX6NOibVaFvPQXVrdBzHM3n0TMknttsPuc jYPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789578522; x=1790183322; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=N28J0VzbFodwXxNV+R6CAv+u3dHEZ4luEdBN+JrJawg=; b=0oDFz47Te4RJAlOVx/Pewh71Yih+KYVKsPwKPe0JPaDrwgkqYvrdAcAdVy3ukz3A5z QlDOxfXcz06howrtrEp419pX8KoJdr0NNED7jS+kHZrVMBILLEr2M+lWoKPaKYIRAwxK khrxuv51C0G+dLXBD14uWL4EwNMeMJ2s9FEoE93nR/lpDuxohNRevWfh0g9mdViO16uc Zu2x/iJN4spZcXZcuCzzEglDhjtI+SFFXFBGcRGZ76xAQHIRvacy5EvGj36jFmr+qK5Q baXeZOV8DGSxd6IRMRZAYnJ/yzO0i6+HUWWCCJW6esc40TLJFs6WM2M3OUDs+3w1ZfHm y5BA== X-Gm-Message-State: AFuF++ljsLFz86h7VHQnCf8V5hdolWCubdrHghQfWwW8Pp1LUgbQUiiL Rj/SqKHty+IHAs01M9EpTIdhoFYAZafNs4knSUOVeoQLvqjBMY/wTi4l X-Gm-Gg: AYBFou0H3qfFqrZtp5ymmabq9nhqMsahtCtQPz9Wodj8zTx3zUiWOMyZKidK+qysXCR VxI5pxlvUR2Djw7pEdS/0k1dqv/84EZLCBpnxP0KgQOVcwmd1qK2he8iAF5vekOFGMkFGxMoRRe vVJsG8XM3p+PhleV0zQbzKTJA1zyK0knh8JYNhH2YMhMr2/83+Er2WDuGaHk1D276AMTEcKxBt0 7ipCAsAOh/1d5XHI0cc3e9aWtbKUPO9qIDQiSqh6wA9U6naPUWC425qzPeDlPP8q/nmpCxrssiq QpKtfhlL+aTMFsCuL27lp30Fd+nnzC5tKQB9EGJqWnDpziTdeGs6KYaDeb3gmc91eHTJffLgEkO sU5GqagkvvCHFoJHzULJZdTFoGbfoq7m4dQu1T/3dLpjIPQCXVK2oSbrqbdHSM66/ZGsyoVLpBk FsOlZqt3aDqSZxsq8pTJ7rHhYK89MVuhKfzGMBkoMypMzjnFoqG1UU66LAdSUgHzk9izPh8EK2c AnqNSmoV+pF9gswD/VizxrJonheoC+uymJmFAgq8lt6nsA= X-Received: by 2002:a05:600c:1992:b0:49b:8f5e:51fb with SMTP id 5b1f17b1804b1-49fbd1af43dmr5334825e9.3.1789578521921; Wed, 16 Sep 2026 10:08:41 -0700 (PDT) Received: from ?IPV6:2a03:83e0:1126:4:4a5e:f479:a4b6:a0f2? ([2620:10d:c092:500::7:90fe]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49fbd23f4e6sm5453365e9.8.2026.09.16.10.08.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Sep 2026 10:08:41 -0700 (PDT) Message-ID: Date: Wed, 16 Sep 2026 18:08:39 +0100 Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH bpf-next v2] libbpf: Fix program log buffer size validation To: Luis Vieira , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Eduard Zingerman , Kumar Kartikeya Dwivedi , Martin KaFai Lau , Song Liu , Yonghong Song , Jiri Olsa , Emil Tsalapatis , Ihor Solodrai Cc: bpf@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260915-libbpf-log-buf-fix-v2-1-2feca3fa4842@gmail.com> Content-Language: en-US From: Mykyta Yatsenko In-Reply-To: <20260915-libbpf-log-buf-fix-v2-1-2feca3fa4842@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 9/15/26 7:13 PM, Luis Vieira wrote: > bpf_program__set_log_buf() checks the existing prog->log_size instead > of the incoming log_size argument when enforcing the UINT_MAX limit. > As a result, an oversized value can be accepted. > > The setter also accepts a non-NULL log_buf with a zero log_size, while > bpf_prog_load() rejects mismatched log buffer and size values. > > Validate the log buffer and size pair consistently with bpf_prog_load(), > and check the supplied log_size against UINT_MAX. > > Signed-off-by: Luis Vieira > --- > Changes in v2: > - Target bpf-next instead of bpf and drop the Fixes tag. > - Drop the regression selftest. > - Validate log_buf and log_size consistently with bpf_prog_load(). > - Link to v1: https://patch.msgid.link/20260914-libbpf-log-buf-fix-v1-1-f592caffcc71@gmail.com > > To: Andrii Nakryiko > To: Eduard Zingerman > To: Ihor Solodrai > To: Alexei Starovoitov > To: Daniel Borkmann > To: Kumar Kartikeya Dwivedi > To: Martin KaFai Lau > To: Song Liu > To: Yonghong Song > To: Jiri Olsa > To: Emil Tsalapatis > Cc: bpf@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > --- Acked-by: Mykyta Yatsenko > tools/lib/bpf/libbpf.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c > index 613afae26519..f7a0517d8fa8 100644 > --- a/tools/lib/bpf/libbpf.c > +++ b/tools/lib/bpf/libbpf.c > @@ -9966,9 +9966,9 @@ const char *bpf_program__log_buf(const struct bpf_program *prog, size_t *log_siz > > int bpf_program__set_log_buf(struct bpf_program *prog, char *log_buf, size_t log_size) > { > - if (log_size && !log_buf) > + if (!!log_buf != !!log_size) > return libbpf_err(-EINVAL); > - if (prog->log_size > UINT_MAX) > + if (log_size > UINT_MAX) > return libbpf_err(-EINVAL); > if (prog->obj->state >= OBJ_LOADED) > return libbpf_err(-EBUSY); > > --- > base-commit: 5ef40d69b38a93bc9951dadb1a15c85c597e1a40 > change-id: 20260913-libbpf-log-buf-fix-49f5038caa5d > > Best regards, > -- > Luis Vieira >