From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A525C6FA82 for ; Thu, 22 Sep 2022 09:10:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229619AbiIVJKp (ORCPT ); Thu, 22 Sep 2022 05:10:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48610 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229611AbiIVJKo (ORCPT ); Thu, 22 Sep 2022 05:10:44 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 341E53135D for ; Thu, 22 Sep 2022 02:10:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1663837842; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=morPVWV2ApZvdpDztZBUk6AXlt+AabwlvFbLlrqV78g=; b=U9H95KA/SbvrMo6v0zO65elzhJ2uL9CldbGbJpoMS5+FvYM4ffixGK0CklP7EUlCInF4+a Zum6nSSKZCQSOukhXcic4yJ3T/nno2zEr9hPQCBTmfRw9pCGkQcKuWUygk0+SodyvFxAP+ uIM7tJQ9H+noUsy6Nr/VcKs8K2qvFzA= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-10-_LUui1INPGaEtIV7YAgJDQ-1; Thu, 22 Sep 2022 05:10:41 -0400 X-MC-Unique: _LUui1INPGaEtIV7YAgJDQ-1 Received: by mail-wr1-f70.google.com with SMTP id g19-20020adfa493000000b0022a2ee64216so3075326wrb.14 for ; Thu, 22 Sep 2022 02:10:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date; bh=morPVWV2ApZvdpDztZBUk6AXlt+AabwlvFbLlrqV78g=; b=nM+tw2OAai54BVemlo1gOta8pfPH7I3EMj1QF++2ZsLLzCPAlrJgJwMN608XFM2rV4 Bo6wA6EB7K7QP5SjbQaH7hdk6gMTKhDj2RMj3jILb81zsnfsEuhtRn6xJvSt4TQBsylM UFEr1ikwi0WjUe6pIxl+wZIiwrqZlMdtjEZVd98vI0M5ByAMSvCX/W/STpJzHSYJhBFH URV20aa8CAHCmzjvLZ2OSUxJBS0/CywNuUgx+K4zYbW473c8WYD+lEH66Q7Mfb0kBrbT uCb4EQW0CbHdv1MDCZrfTQATTYK+sXEiLj7SOG84ufHiZuxNED14vqHR4NPXqqE6g9fP Qcog== X-Gm-Message-State: ACrzQf1KO2zFBPwi3R6WimoToZqpt8IJnicNkoVLmpzYeeM5IOizRJLX HUE2mYfADIEvv0LwxWyLCvhAV15i+U/1RVqk94RlI1rSRN5XyIMw59gKBRS47RKednyG80/6xNM lBkw13Ab7ejR7 X-Received: by 2002:a5d:5b19:0:b0:22b:237c:3de8 with SMTP id bx25-20020a5d5b19000000b0022b237c3de8mr1273133wrb.285.1663837839814; Thu, 22 Sep 2022 02:10:39 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7VpYxGn7XvbqoxWHkJ4g1p2oLdCxcI0CJ5KNSjNQGKsAc575PVXhFFaCl71jQAm7KG4p3Ttw== X-Received: by 2002:a5d:5b19:0:b0:22b:237c:3de8 with SMTP id bx25-20020a5d5b19000000b0022b237c3de8mr1273106wrb.285.1663837839605; Thu, 22 Sep 2022 02:10:39 -0700 (PDT) Received: from gerbillo.redhat.com (146-241-104-76.dyn.eolo.it. [146.241.104.76]) by smtp.gmail.com with ESMTPSA id i10-20020a05600c354a00b003b462b314e7sm5498478wmq.16.2022.09.22.02.10.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Sep 2022 02:10:38 -0700 (PDT) Message-ID: Subject: Re: [PATCH] Do not name control queue for virtio-net From: Paolo Abeni To: "Michael S. Tsirkin" , Junbo Cc: Jesper Dangaard Brouer , Daniel Borkmann , netdev@vger.kernel.org, John Fastabend , Alexei Starovoitov , virtualization@lists.linux-foundation.org, Eric Dumazet , Jakub Kicinski , bpf@vger.kernel.org, "David S. Miller" , linux-kernel@vger.kernel.org Date: Thu, 22 Sep 2022 11:10:37 +0200 In-Reply-To: <20220918081713-mutt-send-email-mst@kernel.org> References: <20220917092857.3752357-1-junbo4242@gmail.com> <20220918025033-mutt-send-email-mst@kernel.org> <20220918081713-mutt-send-email-mst@kernel.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.4 (3.42.4-2.fc35) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Sun, 2022-09-18 at 08:17 -0400, Michael S. Tsirkin wrote: > On Sun, Sep 18, 2022 at 05:00:20PM +0800, Junbo wrote: > > hi Michael > > > > in virtio-net.c > >     /* Parameters for control virtqueue, if any */ > >     if (vi->has_cvq) { > >         callbacks[total_vqs - 1] = NULL; > >         names[total_vqs - 1] = "control"; > >     } > > > > I think the Author who write the code > > wait, that was not you? I believe 'the Author' refers to the author of the current code, not to the author of the patch. @Junbo: the control queue is created only if the VIRTIO_NET_F_CTRL_VQ feature is set, please check that in your setup. Thanks Paolo