From: JP Kobryn <inwardvessel@gmail.com>
To: Yonghong Song <yonghong.song@linux.dev>
Cc: Alexei Starovoitov <ast@kernel.org>,
Andrii Nakryiko <andrii@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
bpf@vger.kernel.org, kernel-team@fb.com,
Martin KaFai Lau <martin.lau@kernel.org>,
Ihor Solodrai <ihor.solodrai@linux.dev>
Subject: Re: [PATCH bpf-next] selftests/bpf: Fix selftest btf_tag/btf_type_tag_percpu_vmlinux_helper failure
Date: Fri, 30 May 2025 17:24:55 -0700 [thread overview]
Message-ID: <f5ce8d33-23a7-408b-a18a-db75ee56d9d5@gmail.com> (raw)
In-Reply-To: <20250529201151.1787575-1-yonghong.song@linux.dev>
On 5/29/25 1:11 PM, Yonghong Song wrote:
> Ihor Solodrai reported selftest 'btf_tag/btf_type_tag_percpu_vmlinux_helper'
> failure ([1]) during 6.16 merge window. The failure log:
>
> ...
> 7: (15) if r0 == 0x0 goto pc+1 ; R0=ptr_css_rstat_cpu()
> ; *(volatile int *)rstat; @ btf_type_tag_percpu.c:68
> 8: (61) r1 = *(u32 *)(r0 +0)
> cannot access ptr member updated_children with moff 0 in struct css_rstat_cpu with off 0 size 4
>
> Two changes are needed. First, 'struct cgroup_rstat_cpu' needs to be
> replaced with 'struct css_rstat_cpu' to be consistent with new data
> structure. Second, layout of 'css_rstat_cpu' is changed compared
> to 'cgroup_rstat_cpu'. The first member becomes a pointer so
> the bpf prog needs to do 8-byte load instead of 4-byte load.
>
> [1] https://lore.kernel.org/bpf/6f688f2e-7d26-423a-9029-d1b1ef1c938a@linux.dev/
>
> Cc: Ihor Solodrai <ihor.solodrai@linux.dev>
> Cc: JP Kobryn <inwardvessel@gmail.com>
> Signed-off-by: Yonghong Song <yonghong.song@linux.dev>
Acked-by: JP Kobryn <inwardvessel@gmail.com>
next prev parent reply other threads:[~2025-05-31 0:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-29 20:11 [PATCH bpf-next] selftests/bpf: Fix selftest btf_tag/btf_type_tag_percpu_vmlinux_helper failure Yonghong Song
2025-05-31 0:24 ` JP Kobryn [this message]
2025-06-01 20:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f5ce8d33-23a7-408b-a18a-db75ee56d9d5@gmail.com \
--to=inwardvessel@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=ihor.solodrai@linux.dev \
--cc=kernel-team@fb.com \
--cc=martin.lau@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).