From: Eduard Zingerman <eddyz87@gmail.com>
To: Yonghong Song <yonghong.song@linux.dev>, bpf@vger.kernel.org
Cc: Alexei Starovoitov <ast@kernel.org>,
Andrii Nakryiko <andrii@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
kernel-team@fb.com, Martin KaFai Lau <martin.lau@kernel.org>
Subject: Re: [PATCH bpf-next v2 1/2] bpf: Get better reg range with ldsx and 32bit compare
Date: Fri, 12 Jul 2024 13:50:49 -0700 [thread overview]
Message-ID: <fae1d2787b5340209429c83111cb6a1b92a66308.camel@gmail.com> (raw)
In-Reply-To: <20240712202815.3540564-1-yonghong.song@linux.dev>
[...]
Also,
> + /* Here we would like to handle a special case after sign extending load,
> + * when upper bits for a 64-bit range are all 1s or all 0s.
> + *
> + * Upper bits are all 1s when register is in a rage:
^^^^
I missed 'n' here, sorry
> + * [0xffff_ffff_0000_0000, 0xffff_ffff_ffff_ffff]
> + * Upper bits are all 0s when register is in a range:
> + * [0x0000_0000_0000_0000, 0x0000_0000_ffff_ffff]
> + * Together this forms are continuous range:
> + * [0xffff_ffff_0000_0000, 0x0000_0000_ffff_ffff]
[...]
next prev parent reply other threads:[~2024-07-12 20:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-12 20:28 [PATCH bpf-next v2 1/2] bpf: Get better reg range with ldsx and 32bit compare Yonghong Song
2024-07-12 20:28 ` [PATCH bpf-next v2 2/2] selftests/bpf: Add ldsx selftests for ldsx and subreg compare Yonghong Song
2024-07-12 20:30 ` [PATCH bpf-next v2 1/2] bpf: Get better reg range with ldsx and 32bit compare Alexei Starovoitov
2024-07-12 21:24 ` Yonghong Song
2024-07-12 20:49 ` Eduard Zingerman
2024-07-12 21:29 ` Yonghong Song
2024-07-12 20:50 ` Eduard Zingerman [this message]
2024-07-12 21:30 ` Yonghong Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fae1d2787b5340209429c83111cb6a1b92a66308.camel@gmail.com \
--to=eddyz87@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@fb.com \
--cc=martin.lau@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox