From: Eduard Zingerman <eddyz87@gmail.com>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>,
Yonghong Song <yonghong.song@linux.dev>,
"Jose E. Marchesi" <jose.marchesi@oracle.com>
Cc: Tao Lyu <tao.lyu@epfl.ch>, Andrii Nakryiko <andrii@kernel.org>,
Alexei Starovoitov <ast@kernel.org>, bpf <bpf@vger.kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Hao Luo <haoluo@google.com>,
Martin KaFai Lau <martin.lau@linux.dev>,
mathias.payer@nebelwelt.net, meng.xu.cs@uwaterloo.ca,
sanidhya.kashyap@epfl.ch, Song Liu <song@kernel.org>
Subject: Re: [PATCH] C inlined assembly for reproducing max<min
Date: Wed, 22 Nov 2023 20:39:24 +0200 [thread overview]
Message-ID: <fd1defcbd087bdd145694298a8e82acc3e244831.camel@gmail.com> (raw)
In-Reply-To: <CAADnVQJqmpSoABqd-dCQBU2ExiPda1mHz2pKHv2jzpSMYFMeqQ@mail.gmail.com>
On Wed, 2023-11-22 at 10:15 -0800, Alexei Starovoitov wrote:
[...]
> > multiclass J<BPFJumpOp Opc, string OpcodeStr, PatLeaf Cond, PatLeaf Cond32> {
> > def _rr : JMP_RR<Opc, OpcodeStr, Cond>;
> > def _ri : JMP_RI<Opc, OpcodeStr, Cond>;
> > @@ -265,6 +329,10 @@ defm JULT : J<BPF_JLT, "<", BPF_CC_LTU, BPF_CC_LTU_32>;
> > defm JULE : J<BPF_JLE, "<=", BPF_CC_LEU, BPF_CC_LEU_32>;
> > defm JSLT : J<BPF_JSLT, "s<", BPF_CC_LT, BPF_CC_LT_32>;
> > defm JSLE : J<BPF_JSLE, "s<=", BPF_CC_LE, BPF_CC_LE_32>;
> > +def JSET_RR : JSET_RR<"&">;
> > +def JSET_RI : JSET_RI<"&">;
> > +def JSET_RR_32 : JSET_RR_32<"&">;
> > +def JSET_RI_32 : JSET_RI_32<"&">;
> > }
> >
> > // ALU instructions
> >
> > can solve your inline asm issue. We will discuss whether llvm compiler
> > should be implementing this instruction from source or not.
>
> I'd say 'yes'. clang/llvm should support such asm syntax.
>
> Jose, Eduard,
> Thoughts?
I agree, since instruction is documented it should have assembly
representation. All other instructions from instruction-set.rst seem
to have one.
next prev parent reply other threads:[~2023-11-22 18:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-21 17:32 max<min after jset Tao Lyu
2023-11-22 0:25 ` Yonghong Song
2023-11-22 14:40 ` [PATCH] C inlined assembly for reproducing max<min Tao Lyu
2023-11-22 18:08 ` Yonghong Song
2023-11-22 18:15 ` Alexei Starovoitov
2023-11-22 18:37 ` Jose E. Marchesi
2023-11-22 18:51 ` Yonghong Song
2023-11-22 18:39 ` Eduard Zingerman [this message]
2023-11-28 4:16 ` max<min after jset Yonghong Song
2023-12-02 10:44 ` [PATCH] C inlined assembly for reproducing max<min Tao Lyu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd1defcbd087bdd145694298a8e82acc3e244831.camel@gmail.com \
--to=eddyz87@gmail.com \
--cc=alexei.starovoitov@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=haoluo@google.com \
--cc=jose.marchesi@oracle.com \
--cc=martin.lau@linux.dev \
--cc=mathias.payer@nebelwelt.net \
--cc=meng.xu.cs@uwaterloo.ca \
--cc=sanidhya.kashyap@epfl.ch \
--cc=song@kernel.org \
--cc=tao.lyu@epfl.ch \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox