From: Quentin Monnet <qmo@kernel.org>
To: Daniel Borkmann <daniel@iogearbox.net>, ast@kernel.org
Cc: kpsingh@kernel.org, James.Bottomley@hansenpartnership.com,
paul@paul-moore.com, bboscaccy@linux.microsoft.com,
memxor@gmail.com, torvalds@linux-foundation.org,
a.s.protopopov@gmail.com, bpf@vger.kernel.org,
linux-security-module@vger.kernel.org
Subject: Re: [PATCH bpf-next v6 4/8] bpftool: Check EVP_Digest when computing excl_prog_hash
Date: Wed, 8 Jul 2026 09:55:18 +0100 [thread overview]
Message-ID: <fdea847d-340a-4fcf-9df7-870b8d434d5e@kernel.org> (raw)
In-Reply-To: <20260708075343.358712-5-daniel@iogearbox.net>
On 08/07/2026 08:53, Daniel Borkmann wrote:
> bpftool_prog_sign() ignores the return value of EVP_Digest(). If the
> digest computation fails (context allocation failure, or a digest
> fetch failure under OpenSSL), EVP_Digest() returns 0 and leaves the
> output buffer untouched, but the function still reports success.
>
> Fixes: 40863f4d6ef2 ("bpftool: Add support for signing BPF programs")
> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Bpftool changes look good to me, thanks for the fix.
Reviewed-by: Quentin Monnet <qmo@kernel.org>
next prev parent reply other threads:[~2026-07-08 8:55 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-08 7:53 [PATCH bpf-next v6 0/8] Verify BPF signed loader at load time Daniel Borkmann
2026-07-08 7:53 ` [PATCH bpf-next v6 1/8] bpf: Resolve and cache fd_array objects " Daniel Borkmann
2026-07-08 7:53 ` [PATCH bpf-next v6 2/8] bpf: Verify signed loader metadata " Daniel Borkmann
2026-07-08 7:53 ` [PATCH bpf-next v6 3/8] libbpf: Drop in-loader metadata check for load-time verification Daniel Borkmann
2026-07-08 8:15 ` sashiko-bot
2026-07-08 8:20 ` Daniel Borkmann
2026-07-08 7:53 ` [PATCH bpf-next v6 4/8] bpftool: Check EVP_Digest when computing excl_prog_hash Daniel Borkmann
2026-07-08 8:55 ` Quentin Monnet [this message]
2026-07-08 7:53 ` [PATCH bpf-next v6 5/8] bpftool: Cover loader metadata with the program signature Daniel Borkmann
2026-07-08 8:55 ` Quentin Monnet
2026-07-08 7:53 ` [PATCH bpf-next v6 6/8] selftests/bpf: Adjust bpf_map layout in verifier_map_ptr Daniel Borkmann
2026-07-08 8:14 ` sashiko-bot
2026-07-08 8:16 ` Daniel Borkmann
2026-07-08 7:53 ` [PATCH bpf-next v6 7/8] selftests/bpf: Verify load-time signed loader metadata Daniel Borkmann
2026-07-08 8:07 ` sashiko-bot
2026-07-08 8:26 ` Daniel Borkmann
2026-07-08 7:53 ` [PATCH bpf-next v6 8/8] Documentation/bpf: Add BPF signing and enforcement doc Daniel Borkmann
2026-07-08 18:30 ` [PATCH bpf-next v6 0/8] Verify BPF signed loader at load time patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fdea847d-340a-4fcf-9df7-870b8d434d5e@kernel.org \
--to=qmo@kernel.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=a.s.protopopov@gmail.com \
--cc=ast@kernel.org \
--cc=bboscaccy@linux.microsoft.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kpsingh@kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=memxor@gmail.com \
--cc=paul@paul-moore.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox