BPF List
 help / color / mirror / Atom feed
From: Daniel Borkmann <daniel@iogearbox.net>
To: "Toke Høiland-Jørgensen" <toke@redhat.com>,
	"Jesper Dangaard Brouer" <hawk@kernel.org>,
	"Sebastiano Miano" <mianosebastiano@gmail.com>,
	bpf@vger.kernel.org, netdev@vger.kernel.org
Cc: saeedm@nvidia.com, tariqt@nvidia.com, edumazet@google.com,
	kuba@kernel.org, pabeni@redhat.com,
	Samuel Dobron <sdobron@redhat.com>,
	netdev@vger.kernel.org
Subject: Re: XDP Performance Regression in recent kernel versions
Date: Thu, 20 Jun 2024 11:52:22 +0200	[thread overview]
Message-ID: <ff571dcf-0375-6684-b188-5c1278cd50ce@iogearbox.net> (raw)
In-Reply-To: <87wmmkn3mq.fsf@toke.dk>

On 6/19/24 9:17 PM, Toke Høiland-Jørgensen wrote:
> Jesper Dangaard Brouer <hawk@kernel.org> writes:
>> On 18/06/2024 17.28, Sebastiano Miano wrote:
>>> I have been conducting some basic experiments with XDP and have
>>> observed a significant performance regression in recent kernel
>>> versions compared to v5.15.
>>>
>>> My setup is the following:
>>> - Hardware: Two machines connected back-to-back with 100G Mellanox
>>> ConnectX-6 Dx.
>>> - DUT: 2x16 core Intel(R) Xeon(R) Silver 4314 CPU @ 2.40GHz.
>>> - Software: xdp-bench program from [1] running on the DUT in both DROP
>>> and TX modes.
>>> - Traffic generator: Pktgen-DPDK sending traffic with a single 64B UDP
>>> flow at ~130Mpps.
>>> - Tests: Single core, HT disabled
>>>
>>> Results:
>>>
>>> Kernel version |-------| XDP_DROP |--------|   XDP_TX  |
>>> 5.15                      30Mpps               16.1Mpps
>>> 6.2                       21.3Mpps             14.1Mpps
>>> 6.5                       19.9Mpps              8.6Mpps
>>> bpf-next (6.10-rc2)       22.1Mpps              9.2Mpps
>>>
>>
>> Around when I left Red Hat there were a project with [LNST] that used
>> xdp-bench for tracking and finding regressions like this.
>>
>> Perhaps Toke can enlighten us, if that project have caught similar
>> regressions?
>>
>> [LNST] https://github.com/LNST-project/lnst
> 
> Yes, actually, we have! Here's the bugzilla for it:
> https://bugzilla.redhat.com/show_bug.cgi?id=2270408

 > We compared performance of ELN and RHEL9 candidate kernels and noticed significant
 > drop in XDP drop [1] on mlx5 (25G).
 >
 > On any rhel9 candidate kernel we are able to drop 19-20M pkts/sec but on an ELN
 > kernels, we are reaching just 15M pkts/sec (CPU utillization remains the same -
 > around 100%).
 >
 > We don't see such regression on ixgbe or i40e.

It looks like this is known since March, was this ever reported to Nvidia back
then? :/

Given XDP is in the critical path for many in production, we should think about
regular performance reporting for the different vendors for each released kernel,
similar to here [0].

Out of curiosity, @Saeed: Is Nvidia internally regularly assessing XDP perf for mlx5
as part of QA? (Probably not, but I thought I'd ask.)

Thanks,
Daniel

   [0] http://core.dpdk.org/perf-reports/

  reply	other threads:[~2024-06-20  9:52 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-18 15:28 XDP Performance Regression in recent kernel versions Sebastiano Miano
2024-06-19  6:00 ` Tariq Toukan
2024-06-19 15:17   ` Sebastiano Miano
2024-06-19 16:27 ` Jesper Dangaard Brouer
2024-06-19 19:17   ` Toke Høiland-Jørgensen
2024-06-20  9:52     ` Daniel Borkmann [this message]
2024-06-21 12:35       ` Samuel Dobron
2024-06-24 11:46         ` Toke Høiland-Jørgensen
2024-06-30 10:25           ` Tariq Toukan
2024-07-22 10:57             ` Samuel Dobron
2024-06-30 11:43         ` Tariq Toukan
2024-07-22  9:26           ` Dragos Tatulea
2024-07-23  9:52             ` Carolina Jubran
2024-07-24 15:36               ` Toke Høiland-Jørgensen
2024-07-25 12:27                 ` Samuel Dobron
2024-07-26  8:09                 ` Dragos Tatulea
2024-07-29 18:00                   ` Samuel Dobron
2024-07-30 11:04               ` Samuel Dobron
2024-12-11 13:20                 ` Samuel Dobron
2025-01-08  9:26                   ` Carolina Jubran

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ff571dcf-0375-6684-b188-5c1278cd50ce@iogearbox.net \
    --to=daniel@iogearbox.net \
    --cc=bpf@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=hawk@kernel.org \
    --cc=kuba@kernel.org \
    --cc=mianosebastiano@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=saeedm@nvidia.com \
    --cc=sdobron@redhat.com \
    --cc=tariqt@nvidia.com \
    --cc=toke@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox