From: Eduard Zingerman <eddyz87@gmail.com>
To: Daniel Borkmann <daniel@iogearbox.net>,
bpf@vger.kernel.org, ast@kernel.org
Cc: andrii@kernel.org, martin.lau@linux.dev, kernel-team@fb.com,
yonghong.song@linux.dev, Lonial Con <kongln9170@gmail.com>
Subject: Re: [PATCH bpf v1 1/2] bpf: sync_linked_regs() must preserve subreg_def
Date: Wed, 25 Sep 2024 12:48:06 -0700 [thread overview]
Message-ID: <ffb55362a04fcc6e20db4705902e721c639b4245.camel@gmail.com> (raw)
In-Reply-To: <88488499-771a-4179-b959-37a3d8f0cf51@iogearbox.net>
On Wed, 2024-09-25 at 11:44 +0200, Daniel Borkmann wrote:
[...]
> Do we have a Fixes tag for stable?
I think this bug persisted from the beginning:
75748837b7e5 ("bpf: Propagate scalar ranges through register assignments.")
E.g. here is original find_equal_scalars():
static void find_equal_scalars(struct bpf_verifier_state *vstate,
struct bpf_reg_state *known_reg)
{
...
struct bpf_reg_state *reg;
...
*reg = *known_reg;
...
}
And bpf_reg_state for 75748837b7e5 has subreg_def as a member.
I can post v2 with this "Fixes" tag if you'd like.
next prev parent reply other threads:[~2024-09-25 19:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-24 21:08 [PATCH bpf v1 1/2] bpf: sync_linked_regs() must preserve subreg_def Eduard Zingerman
2024-09-24 21:08 ` [PATCH bpf v1 2/2] selftests/bpf: verify that sync_linked_regs preserves subreg_def Eduard Zingerman
2024-09-25 9:44 ` [PATCH bpf v1 1/2] bpf: sync_linked_regs() must preserve subreg_def Daniel Borkmann
2024-09-25 19:48 ` Eduard Zingerman [this message]
2024-09-25 20:17 ` Daniel Borkmann
2024-09-27 23:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ffb55362a04fcc6e20db4705902e721c639b4245.camel@gmail.com \
--to=eddyz87@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@fb.com \
--cc=kongln9170@gmail.com \
--cc=martin.lau@linux.dev \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox