From: Leon Hwang <leon.hwang@linux.dev>
To: Eduard Zingerman <eddyz87@gmail.com>, bpf@vger.kernel.org
Cc: ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org,
toke@redhat.com, martin.lau@kernel.org, yonghong.song@linux.dev,
puranjay@kernel.org, xukuohai@huaweicloud.com, iii@linux.ibm.com,
kernel-patches-bot@fb.com, lkp@intel.com
Subject: Re: [PATCH bpf-next v6 2/3] selftests/bpf: Add a test case to confirm a tailcall infinite loop issue has been prevented
Date: Wed, 9 Oct 2024 13:54:05 +0800 [thread overview]
Message-ID: <ffe99d20-b134-40f4-8185-ba2dafeb511c@linux.dev> (raw)
In-Reply-To: <fe9c1ce8f015b8faf5fe33c027485dcbef8d7905.camel@gmail.com>
On 9/10/24 12:37, Eduard Zingerman wrote:
> On Wed, 2024-10-09 at 00:13 +0800, Leon Hwang wrote:
>> cd tools/testing/selftests/bpf; ./test_progs -t tailcalls
>> 335/26 tailcalls/tailcall_bpf2bpf_freplace:OK
>> 335 tailcalls:OK
>> Summary: 1/26 PASSED, 0 SKIPPED, 0 FAILED
>
> Nit: commit message would be more useful with a small description of
> the added test.
>
Sure. The commit message can be:
Add a test case to confirm that it must fail to attach a tail callee
prog with freplace prog, and must fail to update an extended prog to
prog_array map. It's to prevent an infinite loop issue cause by the
combination of tailcall and freplace.
>>
>> Signed-off-by: Leon Hwang <leon.hwang@linux.dev>
>> ---
>
> Acked-by: Eduard Zingerman <eddyz87@gmail.com>
>
> [...]
>
Thanks,
Leon
next prev parent reply other threads:[~2024-10-09 5:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-08 16:13 [PATCH bpf-next v6 0/3] bpf: Fix tailcall infinite loop caused by freplace Leon Hwang
2024-10-08 16:13 ` [PATCH bpf-next v6 1/3] bpf: Prevent " Leon Hwang
2024-10-09 4:30 ` Eduard Zingerman
2024-10-09 4:42 ` Eduard Zingerman
2024-10-09 5:43 ` Leon Hwang
2024-10-10 0:58 ` Alexei Starovoitov
2024-10-10 2:21 ` Leon Hwang
2024-10-10 14:06 ` Xu Kuohai
2024-10-10 14:27 ` Leon Hwang
2024-10-08 16:13 ` [PATCH bpf-next v6 2/3] selftests/bpf: Add a test case to confirm a tailcall infinite loop issue has been prevented Leon Hwang
2024-10-09 4:37 ` Eduard Zingerman
2024-10-09 5:54 ` Leon Hwang [this message]
2024-10-08 16:13 ` [PATCH bpf-next v6 3/3] selftests/bpf: Add cases to test tailcall in freplace Leon Hwang
2024-10-09 5:04 ` Eduard Zingerman
2024-10-09 6:05 ` Leon Hwang
2024-10-10 0:59 ` Alexei Starovoitov
2024-10-10 1:56 ` Leon Hwang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ffe99d20-b134-40f4-8185-ba2dafeb511c@linux.dev \
--to=leon.hwang@linux.dev \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=iii@linux.ibm.com \
--cc=kernel-patches-bot@fb.com \
--cc=lkp@intel.com \
--cc=martin.lau@kernel.org \
--cc=puranjay@kernel.org \
--cc=toke@redhat.com \
--cc=xukuohai@huaweicloud.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox