From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2920FC282DD for ; Wed, 8 Jan 2020 18:37:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 005232067D for ; Wed, 8 Jan 2020 18:37:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726383AbgAHShy (ORCPT ); Wed, 8 Jan 2020 13:37:54 -0500 Received: from www62.your-server.de ([213.133.104.62]:32830 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725941AbgAHShy (ORCPT ); Wed, 8 Jan 2020 13:37:54 -0500 Received: from sslproxy05.your-server.de ([78.46.172.2]) by www62.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1ipGDG-0001FX-7d; Wed, 08 Jan 2020 19:37:50 +0100 Received: from [2001:1620:665:0:5795:5b0a:e5d5:5944] (helo=linux-3.fritz.box) by sslproxy05.your-server.de with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) (envelope-from ) id 1ipGDF-000UdI-OC; Wed, 08 Jan 2020 19:37:49 +0100 Subject: Re: [PATCH bpf-next v3 0/2] bpftool/libbpf: Add probe for large INSN limit To: Quentin Monnet , Michal Rostecki , bpf@vger.kernel.org Cc: Alexei Starovoitov , Martin KaFai Lau , Song Liu , Yonghong Song , Andrii Nakryiko , Jakub Kicinski , Stanislav Fomichev , Prashant Bhole , Peter Wu , netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20200108162428.25014-1-mrostecki@opensuse.org> <01feb8cd-6e24-91d8-4c78-a489c1170965@netronome.com> From: Daniel Borkmann Message-ID: Date: Wed, 8 Jan 2020 19:37:49 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <01feb8cd-6e24-91d8-4c78-a489c1170965@netronome.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Authenticated-Sender: daniel@iogearbox.net X-Virus-Scanned: Clear (ClamAV 0.101.4/25688/Wed Jan 8 10:56:24 2020) Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On 1/8/20 6:48 PM, Quentin Monnet wrote: > 2020-01-08 17:23 UTC+0100 ~ Michal Rostecki >> This series implements a new BPF feature probe which checks for the >> commit c04c0d2b968a ("bpf: increase complexity limit and maximum program >> size"), which increases the maximum program size to 1M. It's based on >> the similar check in Cilium, although Cilium is already aiming to use >> bpftool checks and eventually drop all its custom checks. >> >> Examples of outputs: >> >> # bpftool feature probe >> [...] >> Scanning miscellaneous eBPF features... >> Large complexity limit and maximum program size (1M) is available >> >> # bpftool feature probe macros >> [...] >> /*** eBPF misc features ***/ >> #define HAVE_HAVE_LARGE_INSN_LIMIT >> >> # bpftool feature probe -j | jq '.["misc"]' >> { >> "have_large_insn_limit": true >> } >> >> v1 -> v2: >> - Test for 'BPF_MAXINSNS + 1' number of total insns. >> - Remove info about current 1M limit from probe's description. >> >> v2 -> v3: >> - Remove the "complexity" word from probe's description. > > Series looks good to me, thanks! > > Reviewed-by: Quentin Monnet Applied, thanks!