From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2019251B182; Fri, 9 Oct 2026 18:41:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791571311; cv=none; b=ASa7Z3pzgQqDCnkoSMJYCc1m/d38rZwasgt/wUD1wQ7ry9BsqLCOZXQcqyOWvDg/Pgs7n8EZaRxE4ydABy/TxGeFsdNEfxdyMz5vi7maCaTAdOR/s11AIwpx/QhkGF8n5He30ppoQR1uxpqwcKKRHRvn23EQtpGWJIT6xDwlJmU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791571311; c=relaxed/simple; bh=koP1Z9CZm/xKMbdyR1YkUTISaE1uE4NJvhP8UiPCNcM=; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type: Date; b=BxC7ndPwABhSpF+onHHo7Bwl2H1sgNoidt7uqM3XCpHIwyENnSofNmxOc7C+CI3+bAS5p3ilPNLHjynQzMiLkXRi5Y0n6eelkZO92QcV50WCXgUwGpU7nP1TBlV2tOf6AkzrwYvtTaW05EQr/lUMpzDpEzHr4Gx8XtwFPkIqc0A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=UBQSQElt; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="UBQSQElt" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 60DA81F000FF; Fri, 9 Oct 2026 18:41:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1791571304; bh=koP1Z9CZm/xKMbdyR1YkUTISaE1uE4NJvhP8UiPCNcM=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=UBQSQEltlf58pXyfBUgcflfQu49vXzilhQkb4oLU+VgUkQv9P2cTQJ/TRv2j4K4Ib 2StTtrKpHTUSrI4kcnhBvAwZYZHMffrFwOJzi6SK8rTEWyTyzZJfi/keWqyHcK2nZv RrTcIldU4n+0YJFu0IxC1F5hregzXEMRMEOhitZ587TqM4fZmNVrbB3u0DizuSxQ6y ofemRYnJeFdW8pCWVGEGiQkwOj1phG/0B4dCYLVtssUEax9PXA9UncpHBrq/m6S9jV vDbspnK0RQ3z/YTkzcNhtbEV3VddY6JkunYr9UtQlUI8WNpvqQXih29qYYVC5rRMVw mxt4h1d1RVjeQ== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v5 21/38] uprobes: remove VM_IO, set VM_MIXEDMAP for mapped kernel pages Reply-To: sashiko-reviews@lists.linux.dev To: =?utf-8?b?TG9yZW56byBTdG9ha2VzIChBUk0p?= Cc: linux-scsi@vger.kernel.org, "Alexander Gordeev" , selinux@vger.kernel.org, linux-perf-users@vger.kernel.org, "Christian Borntraeger" , "Marc Zyngier" , kvm@vger.kernel.org, kvmarm@lists.linux.dev, dri-devel@lists.freedesktop.org, linux-s390@vger.kernel.org, "Vasily Gorbik" , linux-usb@vger.kernel.org, bpf@vger.kernel.org, "Heiko Carstens" , "Oliver Upton" , linux-rdma@vger.kernel.org, linux-trace-kernel@vger.kernel.org In-Reply-To: <20261009-b4-mmap-prepare-vma-flag-sanify-v5-21-923b70125b1e@kernel.org> References: <20261009-b4-mmap-prepare-vma-flag-sanify-v5-0-923b70125b1e@kernel.org> <20261009-b4-mmap-prepare-vma-flag-sanify-v5-21-923b70125b1e@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 09 Oct 2026 18:41:42 +0000 Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: > These are not MMIO pages so VMA_IO_BIT is an inappropriate flag to set. >=20 > Instead, set them VMA_MIXEDMAP_BIT as they are kernel mappings and this is > the appropriate flag to set for those. >=20 > This provides the semantics required - no VMA merging is permitted, but > does not prevent GUP. >=20 > However this has no meaningful impact as these are refcounted and thus can > be GUPed. >=20 > A previous commit already prevented __mm_populate() from being invoked on > XOL areas, which VMA_IO_BIT was previously relied upon to do, so that is = no > longer required. >=20 > Both VMAs set a VMA name, so always_dump_vma() returns true before > vma_dump_size() reaches its VMA_IO_BIT check, and thus there is no change > in core dump behaviour. >=20 > Change this for both the core xol_add_vma() function and the x86-specific > get_uprobe_trampoline() function. >=20 > Reviewed-by: Suren Baghdasaryan > Signed-off-by: Lorenzo Stoakes (ARM) Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261009-b4-mmap-pr= epare-vma-flag-sanify-v5-0-923b70125b1e@kernel.org?part=3D21