Re: [PATCH bpf 2/2] selftests/bpf: Redirect a bare FIN to another socket's egress

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] selftests/bpf: non-standard multi-line comment style in sockmap_basic.c
--

commit 75aa8de4d43476db90b5d4bdecc71a03ce93e92c
Author: Eli Skeggs <kernel@eliskeggs.com>

selftests/bpf: Redirect a bare FIN to another socket's egress

This commit adds a sockmap selftest that redirects a bare FIN from a
half-closed socket to another socket's egress and verifies that data
subsequently redirected from a third socket still transmits without
setting an error on the destination socket.

> diff --git a/tools/testing/selftests/bpf/prog_tests/sockmap_basic.c b/tools/testing/selftests/bpf/prog_tests/sockmap_basic.c
> index 1fef6ec2ba7ae..e1e477ce72b32 100644
> --- a/tools/testing/selftests/bpf/prog_tests/sockmap_basic.c
> +++ b/tools/testing/selftests/bpf/prog_tests/sockmap_basic.c
> @@ -1325,6 +1325,78 @@ static void test_sockmap_multi_channels(int sotype)
>  	test_sockmap_pass_prog__destroy(skel);
>  }
>  
> +/* A bare FIN turns into an empty skb. When redirected to another socket,
> + * verify that it does not break the destination socket's psock. Data
> + * later redirected to the destination socket must still transmit.
> + */
> +static void test_sockmap_skb_verdict_redir_fin(void)

[Severity: Low]
This isn't a bug, but in tools/testing/selftests/bpf/prog_tests/sockmap_basic.c
above test_sockmap_skb_verdict_redir_fin(), the new multi-line comment places
text on the opening /* line. Could this follow the BPF subsystem multi-line
comment style by placing the opening /* on its own line:

/*
 * A bare FIN turns into an empty skb. When redirected to another socket,
 * verify that it does not break the destination socket's psock. Data
 * later redirected to the destination socket must still transmit.
 */

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261025-sockmap-bare-fin-v1-0-bb8feae7c4a7@eliskeggs.com?part=2