From: sashiko-bot@kernel.org
To: "Alexei Starovoitov" <alexei.starovoitov@gmail.com>, bpf@vger.kernel.org
Subject: Re: [PATCH bpf v2 9/9] selftests/bpf: Test one may_goto time slice per prog invocation
Date: Sat, 31 Oct 2026 22:12:11 +0000 [thread overview]
Message-ID: <sashiko-outbox-192196@kernel.org> (raw)
In-Reply-To: <20261031215543.682284-10-alexei.starovoitov@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] selftests/bpf: missing __skip() annotation on dummy_test() in timed_may_goto.c
--
commit 0a2b0627ab964341b75c457825392248b5fb88a8
Author: Alexei Starovoitov <ast@kernel.org>
selftests/bpf: Test one may_goto time slice per prog invocation
This commit adds BPF selftests verifying that a single may_goto time slice
is shared across an entire program invocation, including subprogs and
synchronous callbacks, and extends may_goto_far with subprog test cases.
> diff --git a/tools/testing/selftests/bpf/progs/timed_may_goto.c b/tools/testing/selftests/bpf/progs/timed_may_goto.c
> new file mode 100644
> index 0000000000000..c1c48af808a99
> --- /dev/null
> +++ b/tools/testing/selftests/bpf/progs/timed_may_goto.c
> @@ -0,0 +1,898 @@
[ ... ]
> +#if (defined(__TARGET_ARCH_x86) || defined(__TARGET_ARCH_arm64)) && __clang_major__ >= 18
[ ... ]
> +#else
> +
> +SEC("socket")
> +__description("timed may_goto: not supported dummy test")
> +__success
> +int dummy_test(void)
> +{
> + return 0;
> +}
> +
> +#endif
[Severity: Low]
Should dummy_test() in tools/testing/selftests/bpf/progs/timed_may_goto.c
also include a __skip(...) annotation?
When timed_may_goto.c is built on architectures other than x86_64 and arm64
or with GCC or Clang older than 18, serial_test_timed_may_goto() in
tools/testing/selftests/bpf/prog_tests/timed_may_goto.c runs
RUN_TESTS(timed_may_goto) and returns early. Without __skip(...) on
dummy_test(), test_loader executes the placeholder program and reports OK
instead of SKIP, unlike the other placeholder dummy_test() definitions
updated in commit 8928f5ffdb65 ("selftests/bpf: Report placeholder tests as
SKIP, not OK").
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261031215543.682284-1-alexei.starovoitov@gmail.com?part=9
next prev parent reply other threads:[~2026-10-31 22:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-31 21:55 [PATCH bpf v2 0/9] bpf: One may_goto time slice per prog invocation Alexei Starovoitov
2026-10-31 21:55 ` [PATCH bpf v2 1/9] bpf: Emit timed may_goto for JITed progs only Alexei Starovoitov
2026-10-31 21:55 ` [PATCH bpf v2 2/9] selftests/bpf: Don't cast a pointer to .bss in arena_htab_asm Alexei Starovoitov
2026-10-31 21:55 ` [PATCH bpf v2 3/9] selftests/bpf: Give the first loop of cond_break5 an end Alexei Starovoitov
2026-10-31 21:55 ` [PATCH bpf v2 4/9] selftests/bpf: End the loop of parallel_test_bitmap after 50 ms Alexei Starovoitov
2026-10-31 21:55 ` [PATCH bpf v2 5/9] s390/bpf: Support internal-only MOV instruction to resolve per-CPU addrs Alexei Starovoitov
2026-10-31 22:26 ` bot+bpf-ci
2026-10-31 21:55 ` [PATCH bpf v2 6/9] bpf: Pass a pointer to arch_bpf_timed_may_goto() Alexei Starovoitov
2026-10-31 21:55 ` [PATCH bpf v2 7/9] bpf: One may_goto time slice per prog invocation Alexei Starovoitov
2026-10-31 22:25 ` sashiko-bot
2026-10-31 22:30 ` Alexei Starovoitov
2026-10-31 22:37 ` bot+bpf-ci
2026-10-31 22:50 ` Alexei Starovoitov
2026-10-31 21:55 ` [PATCH bpf v2 8/9] bpf: End bpf_loop() when the time of may_goto is up Alexei Starovoitov
2026-10-31 21:55 ` [PATCH bpf v2 9/9] selftests/bpf: Test one may_goto time slice per prog invocation Alexei Starovoitov
2026-10-31 22:12 ` sashiko-bot [this message]
2026-10-31 22:31 ` Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-192196@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=alexei.starovoitov@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox