Re: [PATCH bpf-next v3 4/5] bpftool: Add attach option for light skeleton generation

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] bpftool: bash completion suggests attach after name in _bpftool()
--

commit f5b94ca511f36c96410ef0757d692a7a6f4ea1cf
Author: Mahe Tardy <mahe.tardy@gmail.com>

bpftool: Add attach option for light skeleton generation

This commit adds an optional attach keyword to bpftool gen skeleton when
generating light skeletons with the loader backend (-L), passing the request
through gen_loader_opts.gen_attach and updating the generated attach and
detach helpers, documentation, and bash completion.

> diff --git a/tools/bpf/bpftool/bash-completion/bpftool b/tools/bpf/bpftool/bash-completion/bpftool
> index a28af31937ad4..9247a9fdcaef9 100644
> --- a/tools/bpf/bpftool/bash-completion/bpftool
> +++ b/tools/bpf/bpftool/bash-completion/bpftool
> @@ -1021,7 +1021,7 @@ _bpftool()
>                              return 0
>                              ;;
>                          *)
> -                            _bpftool_once_attr 'name'
> +                            _bpftool_once_attr 'name attach'

[Severity: Low]
In _bpftool() under the gen -> skeleton case:

                skeleton)
                    case $prev in
                        $command)
                            _filedir
                            return 0
                            ;;
                        *)
                            _bpftool_once_attr 'name attach'
                            return 0
                            ;;
                    esac

When a user types "bpftool gen skeleton <file> name <TAB>", $prev is "name"
and falls through to the wildcard branch. Because "name" is already on the
command line and "attach" is not, won't _bpftool_once_attr 'name attach'
autocomplete "attach" as the object name argument to "name"?

Should there be a "name) return 0 ;;" case before the wildcard branch so
that completion does not suggest "attach" when expecting the user-supplied
object name?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261102201356.5798-1-mahe.tardy@gmail.com?part=4