Re: [PATCH bpf-next v3 26/45] bpf: Update comments about paths, pruning and explored states

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] bpf: non-standard multi-line comment style in updated verifier comments
--

commit de7d08cee08981c083cd91cad28f7bba69ff01a5
Author: Alexei Starovoitov <ast@kernel.org>

bpf: Update comments about paths, pruning and explored states

This commit updates verifier comments in include/linux/bpf_verifier.h,
kernel/bpf/states.c, and kernel/bpf/verifier.c to describe the control-flow
graph fixpoint pass and state joining instead of legacy path exploration and
pruning.

[Severity: Low]
This isn't a bug, but while this patch converts several multi-line comments in
include/linux/bpf_verifier.h, kernel/bpf/states.c (in stacksafe()), and
kernel/bpf/verifier.c (in sanitize_ptr_alu()) to the BPF multi-line comment
style with the opening /* on its own line, several other multi-line comments
updated by this patch still keep text on the opening /* line:

- kernel/bpf/states.c, in the block comment above func_states_equal()
  (starting at line 659)
- kernel/bpf/states.c, inside bpf_state_subsumes() before the old->speculative
  check (starting at line 735)
- kernel/bpf/verifier.c, in the top-level bpf_check() overview comment
  (starting at line 63)
- kernel/bpf/verifier.c, in the block comment above process_iter_next_call()
  (starting at line 8909)
- kernel/bpf/verifier.c, inside prepare_func_exit() before free_func_state()
  (starting at line 12560, which also keeps the closing */ on the same line as
  the comment text on line 12561)
- kernel/bpf/verifier.c, inside mark_ptr_or_null_reg() in the is_null branch
  (starting at line 19192)
- kernel/bpf/verifier.c, inside process_bpf_exit_full() before the
  exception_exit check (starting at line 20656)

Should these updated multi-line comments also place the opening /* and closing
*/ on their own lines to match the BPF coding style?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261106035111.3315285-1-alexei.starovoitov@gmail.com?part=26