From: sashiko-bot@kernel.org
To: "Tiezhu Yang" <yangtiezhu@loongson.cn>
Cc: bpf@vger.kernel.org
Subject: Re: [PATCH bpf-next v2 1/2] selftests/bpf: Skip jit_insns_arena tests if not supported
Date: Mon, 09 Nov 2026 04:25:14 +0000 [thread overview]
Message-ID: <sashiko-outbox-204403@kernel.org> (raw)
In-Reply-To: <20261109041207.15221-2-yangtiezhu@loongson.cn>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] selftests/bpf: incomplete jit_insns_arena skip list in
test_jit_insns()
--
commit 5301df7df06ac60c33f099fbdfa02a082cfa0c99
Author: Tiezhu Yang <yangtiezhu@loongson.cn>
selftests/bpf: Skip jit_insns_arena tests if not supported
This commit probes for BPF_MAP_TYPE_ARENA support in test_jit_insns() and
skips the jit_insns_arena subtests when arena maps are not supported.
> diff --git a/tools/testing/selftests/bpf/prog_tests/jit_insns.c b/tools/testing/selftests/bpf/prog_tests/jit_insns.c
> index 0aaab23a2eef8..e8a0e5ec2d6bf 100644
> --- a/tools/testing/selftests/bpf/prog_tests/jit_insns.c
> +++ b/tools/testing/selftests/bpf/prog_tests/jit_insns.c
> @@ -3688,7 +3688,14 @@ static void test_tail_call(void)
>
> void test_jit_insns(void)
> {
> - RUN_TESTS(jit_insns_arena);
> + if (libbpf_probe_bpf_map_type(BPF_MAP_TYPE_ARENA, NULL)) {
> + RUN_TESTS(jit_insns_arena);
> + } else {
> + if (test__start_subtest("arena_zero_off"))
> + test__skip();
> + if (test__start_subtest("cast_to_user"))
> + test__skip();
> + }
[Severity: Low]
Does this else branch miss the remaining subtests in jit_insns_arena?
Commit a9fee553d3db ("selftests/bpf: Extend the JIT instruction tests for
arm64 encodings") added arena_offsets (built on all architectures) as well as
arena_offsets_ldsx, arena_offsets_atomics, and arena_acq_rel to
tools/testing/selftests/bpf/progs/jit_insns_arena.c. When BPF_MAP_TYPE_ARENA
is unsupported, those subtests are silently omitted rather than registered and
marked skipped, so targeted runs such as ./test_progs -a
jit_insns/arena_offsets match zero subtests.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261109041207.15221-1-yangtiezhu@loongson.cn?part=1
next prev parent reply other threads:[~2026-11-09 4:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-09 4:12 [PATCH bpf-next v2 0/2] selftests/bpf: Handle some unexpected failures Tiezhu Yang
2026-11-09 4:12 ` [PATCH bpf-next v2 1/2] selftests/bpf: Skip jit_insns_arena tests if not supported Tiezhu Yang
2026-11-09 4:25 ` sashiko-bot [this message]
2026-11-09 6:10 ` Tiezhu Yang
2026-11-09 4:12 ` [PATCH bpf-next v2 2/2] selftests/bpf: Fix unaligned access failure in fexit_bpf2bpf Tiezhu Yang
2026-11-09 4:17 ` sashiko-bot
2026-11-09 6:11 ` Tiezhu Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-204403@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=yangtiezhu@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox