Re: [PATCH v5 3/6] selftests/x86: add shadow stack lock test

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] selftests/x86: main() comment references nonexistent
  test_shadow_stack_lock()
--

commit c2aa8d04f3f8897cd4991d5c5c2ee94b8e83b82a
Author: Bill Roberts <bill.roberts@arm.com>

selftests/x86: add shadow stack lock test

This commit adds a selftest that locks the WRSS shadow stack feature and
verifies that subsequent attempts to disable it fail with -EPERM.

> diff --git a/tools/testing/selftests/x86/test_shadow_stack.c b/tools/testing/selftests/x86/test_shadow_stack.c
> index b52c5420c1374..e047f1ceae0a7 100644
> --- a/tools/testing/selftests/x86/test_shadow_stack.c
> +++ b/tools/testing/selftests/x86/test_shadow_stack.c
> @@ -1060,9 +1060,28 @@ int test_ptrace(void)
>  	return 1;
>  }
>  
> +static int test_locking(void)

[ ... ]

> @@ -1079,12 +1098,31 @@ int main(int argc, char *argv[])
>  		return 1;
>  	}
>  
> +	/* Note: test_shadow_stack_lock() needs write enabled */
>  	if (ARCH_PRCTL(ARCH_SHSTK_ENABLE, ARCH_SHSTK_WRSS)) {

[Severity: Low]
This comment refers to test_shadow_stack_lock(), whereas the helper added and
called below is named test_locking().

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261109182758.252223-1-bill.roberts@arm.com?part=3