Re: [RFC bpf-next v3 1/3] bpf: Add KF_CHANGES_PKT kfunc flag

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] bpf: Signed-off-by trailer uses handle instead of full name
--

commit 59e7e83571f6e7abee77827b13a92abbf8a20431
Author: ThisSeanZhang <thisseanzhang@gmail.com>

> bpf: Add KF_CHANGES_PKT kfunc flag
>
> The verifier invalidates packet pointers after a call to a helper that
> may change packet data, see bpf_helper_changes_pkt_data(). Kfuncs have
> no equivalent: bpf_is_kfunc_pkt_changing() special-cases
> bpf_xdp_pull_data() by ID, and the kfuncs that write through a dynptr
> are listed in dynptr_write_kfuncs, because the dynptr type is not known
> when the arguments are checked.
>
> Add KF_CHANGES_PKT so that a kfunc can declare this where it is
> defined, instead of adding another entry to the kfunc lists in the
> verifier. The verifier then invalidates packet pointers after a call to
> such a kfunc, like it does for the equivalent helpers; a stale packet
> pointer kept in a callee-saved register across the call is rejected at
> verification time.
>
> The same predicate is used by the CFG pass to propagate the
> changes_pkt_data property to the callers of a subprogram, so a kfunc
> called through a subprogram is covered as well.
>
> This is needed by the PPPoE encap/decap kfuncs added later in this
> series, which adjust the skb like bpf_skb_adjust_room() does.
>
> Signed-off-by: ThisSeanZhang <thisseanzhang@gmail.com>

[Severity: High]
The Author header and Signed-off-by trailer use a single-word handle
(ThisSeanZhang) rather than a real full name (such as Sean Zhang), as
required by the Developer's Certificate of Origin in
Documentation/process/submitting-patches.rst.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261111032141.525444-1-thisseanzhang@gmail.com?part=1