Re: [PATCH net-next v1 11/15] selftests: drv-net: psp: test socket-less associations and the tc psp action

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] selftests: drv-net: psp: hand-rolled sysctl and polling helpers
  in psp.py
--

commit 97820709dd90b6f5b2af8e09b179cf5d698f9d28
Author: Todd Freed <toddfreed@meta.com>

selftests: drv-net: psp: test socket-less associations and the tc psp action

This commit adds selftests covering PSP socket-less associations and the tc
psp action for control and data paths.

> diff --git a/tools/testing/selftests/drivers/net/psp.py b/tools/testing/selftests/drivers/net/psp.py
> index 473500901879b..fb75444100515 100755
> --- a/tools/testing/selftests/drivers/net/psp.py
> +++ b/tools/testing/selftests/drivers/net/psp.py

[ ... ]

> @@ -683,6 +685,591 @@ def data_mss_adjust(cfg, ipver):
>      _data_mss_adjust(cfg, ipver)
>  
>  
> +#
> +# Socket-less associations and the tc psp action
> +#

[ ... ]

> +def _wait_data_outq(s, exp_len, timeout=5):
> +    """ Like _check_data_outq() but leave time for retransmits """
> +    outq = 0
> +    end = time.monotonic() + timeout
> +    while time.monotonic() < end:
> +        outq = _get_outq(s)
> +        if outq == exp_len:
> +            break
> +        time.sleep(0.05)
> +    ksft_eq(outq, exp_len)

[ ... ]

> +def data_tc_encap_ingress(cfg):
> +    """ Test packets with an assoc aren't redirected to ingress """
> +    _init_psp_dev(cfg)
> +    _require_tc_psp(cfg)
> +
> +    _, tx = _sockless_assocs(cfg)
> +    # Traffic to a local address leaves through lo, and comes back on its
> +    # ingress. With the dst gone, input routing takes a loopback source for
> +    # a martian, and needs accept_local for a local one.
> +    sysctl = "net.ipv4.conf.lo.accept_local"
> +    old = cmd(f"sysctl -n {sysctl}").stdout.strip()
> +    cmd(f"sysctl -w {sysctl}=1")
> +    defer(cmd, f"sysctl -w {sysctl}={old}")

[Severity: Low]
This isn't a bug, but could data_tc_encap_ingress() use
ctl_file_write('/proc/sys/net/ipv4/conf/lo/accept_local', 1) from lib.py
instead of spawning sysctl subprocesses to read, write, and restore the
setting?  Similarly, _wait_data_outq() duplicates the polling loop in
_check_data_outq() and could parameterize _check_data_outq() or use
ksft_busy_wait().

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261111005533.6436-1-toddfreed@meta.com?part=11