Re: [PATCH net-next 2/3] tcp: convert do_tcp_getsockopt() to sockopt_t

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] bpf: non-standard multi-line comment style in
  sol_tcp_getsockopt()
--

commit adc743711fff2b36324cfbce470ae256d9f2a174
Author: Breno Leitao <leitao@debian.org>

tcp: convert do_tcp_getsockopt() to sockopt_t

This commit converts do_tcp_getsockopt() to take a sockopt_t pointer and
updates tcp_getsockopt() and the bpf sol_tcp_getsockopt() helper to pass
one.

> diff --git a/net/core/filter.c b/net/core/filter.c
> index 9b8d5191c4ba2..0d5afe1c5606b 100644
> --- a/net/core/filter.c
> +++ b/net/core/filter.c
> @@ -5686,6 +5686,28 @@ static int bpf_sol_tcp_setsockopt(struct sock *sk, int optname,
>  	return 0;
>  }
>  
> +static int sol_tcp_getsockopt(struct sock *sk, int optname, char *optval,
> +			      int *optlen)
> +{
> +	struct kvec kvec;
> +	sockopt_t opt;
> +	int err;
> +
> +	err = sockptr_to_sockopt(&opt, KERNEL_SOCKPTR(optval),
> +				 KERNEL_SOCKPTR(optlen), &kvec);
> +	if (err)
> +		return err;
> +
> +	/* BPF may call this in softirq: with page faults disabled, the
> +	 * usercopy check skips find_vmap_area() and its lock.
> +	 */

[Severity: Low]
This isn't a bug, but bpf code uses the kernel multi-line comment style
where the opening /* goes on its own line and the comment text starts on
the next line.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261112-getsockopt_phase7-v1-0-1eb759dd0929@debian.org?part=2