Re: [PATCH net-next 1/6] bonding: check XDP support before enslaving changes state

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] bonding: missing Fixes trailer for bond_enslave() XDP check fix
--

commit 13721b74b0f4f7f2e2971839a9fe53fd558da85a
Author: Hangbin Liu <hangbin.liu@linux.dev>

> bonding: check XDP support before enslaving changes state
>
> The XDP capability checks (ndo_bpf/ndo_xdp_xmit) and the slave XDP
> program count check in bond_enslave() run after the slave has already
> been opened, attached and made visible to the datapath. In particular
> the slave can become bond->curr_active_slave, or be published via
> bond->slave_cnt, before we verify that slave_dev->netdev_ops->ndo_xdp_xmit
> exists, so bond_xdp_xmit() may call a NULL ndo_xdp_xmit.
>
> Move both checks to the validation section at the top of bond_enslave(),
> before the first state change. On failure nothing has been mutated yet,
> so the function can return directly. The dev_xdp_propagate() setup is
> left in place for now and still uses the same error path.
>
> Error messages and errno values are unchanged (-EOPNOTSUPP with the
> same netlink extack strings), and the success path is unaffected
> beyond running the read-only checks earlier.
>
> Signed-off-by: Hangbin Liu <liuhangbin@kylinos.cn>

[Severity: Low]
Since this fixes a NULL ndo_xdp_xmit dereference when enslaving a slave
on an XDP-enabled bond, should it include a Fixes: tag?

  Fixes: 9e2ee5c7e7c3 ("net, bonding: Add XDP support to the bonding driver")

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261113-bond_enslave_restruct-v1-0-364c549e78db@kylinos.cn?part=1